-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update button component previews #58
Conversation
- removes background color - shows each button in just one color, removes other examples - adds dropdown buttons
Which are the "dropdown buttons with icons?" I can see what is missing for them to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
If you want to add a commit to make the dropdown buttons work, that would be amazing! I included three examples in the buttons with icons section:
The options that appear in the dropdown lists can get taked from the real examples of them in use on the calendar: https://www.fec.gov/calendar/ |
Woohoo! Thanks @xtine, I ran your additions locally and they look good, so since you approved the review, I'll merge 🔆 |
Summary
Notes for review