Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button component previews #58

Merged
merged 6 commits into from
Mar 5, 2018
Merged

Conversation

jenniferthibault
Copy link
Contributor

Summary

  • Updates the button component based on criteria set in Adjust buttons component so that it's up to date and accurate #57
    • Basic: Remove active state. The active state will be shown through the toggle component
    • Basic: Add more spacing between buttons so that they don't look so much like toggles
    • Icons: Show each button in just one color—color changes can be determined by the basic tab, and this will cut down clutter
    • Icons: Add dropdown buttons. These examples were missing from the components
    • Sizes: Remove the colored background slab to be consistent
  • Adds additional toggle button examples discovered during research

screen shot 2018-02-26 at 9 51 06 am

screen shot 2018-02-26 at 9 50 52 am

screen shot 2018-02-26 at 9 50 36 am

Notes for review

jenniferthibault added 4 commits February 26, 2018 09:34
- removes background color
- shows each button in just one color, removes other examples
- adds dropdown buttons
@jenniferthibault jenniferthibault changed the title Update buttons Update button component previews Feb 26, 2018
@jenniferthibault jenniferthibault changed the base branch from master to add-component-notes February 27, 2018 16:18
@xtine
Copy link
Contributor

xtine commented Feb 28, 2018

Which are the "dropdown buttons with icons?" I can see what is missing for them to work.

Copy link
Contributor

@xtine xtine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jenniferthibault
Copy link
Contributor Author

If you want to add a commit to make the dropdown buttons work, that would be amazing!

I included three examples in the buttons with icons section:

  • Subscribe
  • Download
  • Add to calendar

The options that appear in the dropdown lists can get taked from the real examples of them in use on the calendar: https://www.fec.gov/calendar/

screen shot 2018-02-27 at 7 58 48 pm

@xtine
Copy link
Contributor

xtine commented Feb 28, 2018

Hooked up the button icon dropdowns:
screen shot 2018-02-27 at 6 52 31 pm

Bonus: got the favicon working!
screen shot 2018-02-27 at 6 54 39 pm

@jenniferthibault jenniferthibault changed the base branch from add-component-notes to master March 5, 2018 17:41
@jenniferthibault
Copy link
Contributor Author

Woohoo! Thanks @xtine, I ran your additions locally and they look good, so since you approved the review, I'll merge 🔆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust buttons component so that it's up to date and accurate
2 participants