This repository has been archived by the owner on May 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
(Include a summary of proposed changes and connect issue below)
Networkx 2.6 upgrade highlights:
Replace deprecated method .node with .nodes in regulation-parser
(also updated gitdb and smmap version bc I was getting circular dependency issue when I pulled the parser repo)
Required reviewers
2-3 devs
Impacted areas of the application
General components of the application that this PR will affect:
Related PRs
Regulations-Parser PR:
fecgov/regulations-parser#3
How to test
(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)
Terminal#1:
pyenv virtualenv 3.7.12 venv-eregs-3712
pyenv activate venv-eregs-3712
-e git+https://github.com/fecgov/regulations-parser.git@master#egg=regparser
to:
-e git+https://github.com/fecgov/[email protected]#egg=regparser
-e git+https://github.com/fecgov/regulations-parser.git@master#egg=regparser
to:
-e git+https://github.com/fecgov/[email protected]#egg=regparser
(The above will point to my updated branch which I will merge into regulations parser if everyone approves this PR)
pip install -r requirements.txt
(make sure you're using version 22.0.4 of pip or upgrade according to warning and re-run) (also it will ask you if you want to use the old version or switch and you should types
)rm -rf node_modules
rm -rf src
npm i
(you can make sure you're running the proper version withnvm install v.14.15.5
)npm audit fix
npm run build
dropdb eregs-db
if the eregs database already exist.createdb eregs-db
(same name as defined in local_settings.py)create a new local_settings.py with the following configuration if one doesn't exist:
python manage.py migrate
python manage.py compile_frontend
(if you don't already have a compiled folder thenmkdir compiled
)python manage.py runserver
(leave this running)Terminal#2:
pyenv virtualenv 3.7.12 venv-parser-3712
pyenv activate venv-parser-3712
pip install -r requirements-parsing.txt
(same as above with pip version 22.0.4) NOTE: You will see a warning about networkx being ysnyk test --file=requirements-parsing.txt --package-manager=pip
(you should not see the networkx issue anymore, but you will see the django and numpy issues that will be addresssed in [Snyk:High] django SQL Injection (due by 05/13/2022) #681)python load_regs/load_fec_regs.py local
This is my first time with e-regs, so please let me know if there's improvements I can make! Constructive criticism super welcome.