Feature/link-block #728
Merged
Feature/link-block #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahmanger
commented
Jan 11, 2017
| @@ -12,13 +12,6 @@ | |||
| populateToolbar: function(toolbar) { | |||
| var button, widget; | |||
|
|
|||
| var getEnclosing = function(tag) { | |||
There was a problem hiding this comment.
Just noting that this is removed because it wasn't actually being used.
noahmanger
commented
Jan 11, 2017
| @@ -5,29 +5,7 @@ | |||
| @hooks.register('construct_whitelister_element_rules') | |||
| def whitelister_element_rules(): | |||
| return { | |||
| # Commenting out disallowed tags so its easier to remember & revert | |||
| 'a': attribute_rule({'href': check_url}), | |||
There was a problem hiding this comment.
I learned that these rules are the default ones, so we don't need to include them... just the ones that we want to add.
xtine
approved these changes
Jan 11, 2017
| li.sequence-member .sequence-member-inner .sequence-type-list .sequence-container-inner { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .t-sans { | ||
| font-family: sans-serif; |
There was a problem hiding this comment.
Does it not get this class from fec-style?
There was a problem hiding this comment.
This stylesheet is loaded by the admin interface, which doesn't load fec-style. I added this as a one-off style so that you can know that the button works.
|
Woohoo! Just popping into this PR to say how exciting this work is 💟 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple more capabilities to the CMS.
First, it adds a new button to the rich text controls that is used to make a link sans-serif:
Which gets us this:
Second, it adds a new block to the
sectionStreamField to insert links to other pages, which will be used to get this sort of component on the new Candidate and Committee Services page (ignore the copy...these are just random pages in a random place for illustration purposes):