-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6570 - Icons and meta data #6571
Open
rfultz
wants to merge
7
commits into
develop
Choose a base branch
from
feature/icons-and-meta-data
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly size updates, but also removed "This site is in beta" message from the print-only site header/seal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6571 +/- ##
========================================
Coverage 79.72% 79.72%
========================================
Files 235 235
Lines 5159 5159
========================================
Hits 4113 4113
Misses 1046 1046 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Include a summary of proposed changes and connect issue below)
Required reviewers
Impacted areas of the application
Meta data site-wide and various social sharing images and thumbnails:
apple-touch-icon
HandheldFriendly
andMobileOptimized
meta data tags (used for very old versions of BlackBerry and Windows Mobile devices)/general/favicons-*.png
, updating to "FEC.gov" instead of "The new FEC.gov" since the site's been standard for more than five yearsSTART_YEAR
andEND_YEAR
window vars since the front-end isn't referencing them inside JavaScriptScreenshots
The new images are in Files Changed but otherwise won't show up until this is merged, deployed, and crawled again
Related PRs
There's another issue/PR for the canonical tag so we aren't touching those here.
How to test
npm run build
START_YEAR
?END_YEAR
?TRANSITION_URL
?<link rel="icon"
href
values are accurate<link rel="apple-touch-icon"
href
values are accurate