6207-pin sqlparse to remove snyk vulnerability #6253
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Sqlparse is brought in by Django, we need to pin it to remove a snyk vulnerability until Django updates their min version (they have not yet in the current version)
Required reviewers
2 devs
Impacted areas of the application
General components of the application that this PR will affect:
How to test
(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)
snyk test --file=requirements.txt --package-manager=pip
pyenv activate <new virtualenv>
pip install -r requirements.txt
npm install
npm run build
pytest
cd fec/
./manage.py runserver
snyk test --file=requirements.txt --package-manager=pip
sqlparse vuln should be gone