Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Sitemaps for reports and FECForms - working prototypes #5958

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Oct 16, 2023

Summary

Reports (about the FEC):

  • Get all DocumentPage descendants of DocumentFeedPage and use the file_url as the sitemap loc entry
  • lastmod entry is the last time that DocumentPage was updated
  • Make document pages in Reports about the FEC private to remove then from Wagtail sitemap in favor of indexing the PDFs themselves with the report sitemap.

FECForms:

  • Gets all items from the wagtaildocuments.document model where the file name starts with fecfrm
  • The lastmod is when the doc was created in Wagtail. Not sure if there is a way to get the last time a document was changed.
  • The rest of the forms are in the polcy-guidance folder in the S3 and get indexed through that search affiliate.

FYI- This branch has a dev deploy task in tasks.py.
FYI- The only file you need for the sitemaps is urls.py, Ignore changes to the other four files: models.py, document_page.html, document.html, filters.py, those changes were WIP for other related issues.

  • Resolves #issue_number

Related issue: #5918

Required reviewers

(Include who is required to review prior to merge. For example: One designer and two front end developer reviews are required prior to merge)

Impacted areas of the application

General components of the application that this PR will affect:

Screenshots

(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)

Related PRs

Related PRs against other branches:

branch PR
fix/other_pr link
feature/other_pr link

How to test

(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)

System architecture updates (if applicable)

(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)

@johnnyporkchops johnnyporkchops changed the title [DRAFT] Working prototypes for reports and forms sitemaps [DRAFT] Sitemaps for reports and forms - working prototypes Oct 27, 2023
@johnnyporkchops johnnyporkchops changed the title [DRAFT] Sitemaps for reports and forms - working prototypes [DRAFT] Sitemaps for reports and FECForms - working prototypes Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants