Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disbursement search language #5938

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

djgarr
Copy link
Contributor

@djgarr djgarr commented Oct 2, 2023

Summary

Please review

Double check the language in the ticket "Search select disbursements from committees by the recipient, purpose, amount and date. Excludes outside spending to support or oppose candidates and allocated federal/nonfederal disbursements.” made it through to the PR

Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine. One suggestion for consideration - do you want to link "allocated federal/nonfederal disbursements" to https://www.fec.gov/help-candidates-and-committees/making-disbursements-political-party/#indirect-candidate-support-party-building-activities? (That is the part of H4CC that covers them for party committees. There are pages for nonconnected and SSFs as well, but most of the data is from party committees, I'm thinking.)

@djgarr
Copy link
Contributor Author

djgarr commented Oct 3, 2023

@dorothyyeager Thanks for the suggestion. I ran it by Myles and he made the same point about multiple committee types possibly having allocated disbursements (although probably mostly from party committees) and them excluded from the results. I think at this time leaving it unlinked is best

@rfultz rfultz merged commit effd5f8 into develop Oct 17, 2023
@rfultz rfultz deleted the feature/disbursement-language-update branch October 17, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Disbursement Search Language on Spending Browse Data
4 participants