Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Reporting dates tables wagtail template 2.0 #5711

Closed

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Apr 20, 2023

Summary

The WIP spreadsheet (with data and html tabs) used to populate the Wagtail table block is here:https://docs.google.com/spreadsheets/d/1-gQCFHZyl-GnOKGxPee437r93dzhx5yn_oPXVp3TkqE/edit#gid=1367081466

Related:
#4408
#4406
#3817


(Include a summary of proposed changes and connect issue below)

Required reviewers

(Include who is required to review prior to merge. For example: One designer and two front end developer reviews are required prior to merge)

Impacted areas of the application

General components of the application that this PR will affect:

Screenshots

(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)

Related PRs

Related PRs against other branches:

branch PR
fix/other_pr link
feature/other_pr link

How to test

(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)

System architecture updates (if applicable)

(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #5711 (2a4efa3) into develop (395a0ce) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #5711      +/-   ##
===========================================
+ Coverage    78.16%   78.20%   +0.04%     
===========================================
  Files          282      283       +1     
  Lines         9286     9305      +19     
  Branches       650      650              
===========================================
+ Hits          7258     7277      +19     
  Misses        2028     2028              
Impacted Files Coverage Δ
fec/home/blocks.py 100.00% <100.00%> (ø)
fec/home/migrations/0126_reportingdatestable.py 100.00% <100.00%> (ø)
fec/home/models.py 88.31% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@johnnyporkchops johnnyporkchops changed the title [DRAFT] Reporting dates tables wagtail template [DRAFT] Reporting dates tables 2.0 wagtail template Apr 20, 2023
@johnnyporkchops johnnyporkchops changed the title [DRAFT] Reporting dates tables 2.0 wagtail template [DRAFT] Reporting dates tables wagtail template 2.0 Apr 20, 2023
@johnnyporkchops
Copy link
Contributor Author

Closing to make a new PR off latest develop branch...this one has gotten stale.

@johnnyporkchops johnnyporkchops deleted the feature/5317-reporting-dates-table-template branch June 30, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant