Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MUR search results display #5319

Merged
merged 6 commits into from
Jul 20, 2022

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Jun 28, 2022

Summary

Update MUR search results display with:

  • election cycle
  • disposition
  • subject
  • document name
  • document links
  • document type
  • removed ellipses
  • force all-caps for committee name

Required reviewers

1 front-end and 1 UX

Impacted areas of the application

General components of the application that this PR will affect:

Screenshots

Screen Shot 2022-07-07 at 3 42 51 PM

How to test

@JonellaCulmer
Copy link
Contributor

Screen Shot 2022-06-29 at 11 21 12 AM

@patphongs
Copy link
Member Author

@JonellaCulmer I updated the search results display as discussed:

  • Change matches column name to "Case details and documents"
  • Seperate MUR case name into new column
  • Seperate MUR number into new column
  • Increase spacing between docs
  • Add dividing line between Disposition and Documents
  • Move + icon to the left
  • Make it "# more matches" or "1 more match"
  • Remove white space between document name and icon
  • Remove extra border line to the left of the accordion button

Screen Shot 2022-06-29 at 4 48 20 PM

@JonellaCulmer
Copy link
Contributor

@patphongs Here are my followup comments:
Screen Shot 2022-06-29 at 5 26 17 PM

@patphongs
Copy link
Member Author

@JonellaCulmer Thanks for your follow-up comments. I have tightened up the spacing in the 3 areas that you spotted above. Please take a look to see if that's better.

Screen Shot 2022-07-07 at 3 42 51 PM

@codecov-commenter
Copy link

Codecov Report

Merging #5319 (024c3cc) into develop (5a12777) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5319   +/-   ##
========================================
  Coverage    75.07%   75.07%           
========================================
  Files          125      125           
  Lines         8131     8131           
  Branches       648      648           
========================================
  Hits          6104     6104           
  Misses        2027     2027           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a12777...024c3cc. Read the comment docs.

@rfultz
Copy link
Contributor

rfultz commented Jul 18, 2022

Is it a big deal that the left margin/padding is tight on the smallest width? (Left side of "MUR" and the name) Or is that just part of the general issue across the site?
image

@rfultz
Copy link
Contributor

rfultz commented Jul 18, 2022

.cell-15 is too narrow at the medium widths
image

Adding something like

.simple-table__cell:nth-child(2) {
  word-break: break-word;
}

would do this
image

@patphongs
Copy link
Member Author

too narrow at the medium widths

@rfultz Thanks for the suggestion! I've added the word break for medium widths.

left margin/padding is tight on the smallest width

I think this is an artifact of all of our datatables. There's a 1 rem padding. If we update the padding for the tables, we should do it for all. But I don't want to do it within this PR, we can think about that in a separate one.

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for everything, Pat!

@JonellaCulmer JonellaCulmer merged commit 7d986d7 into develop Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update results display for MUR search
4 participants