-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MUR search results display #5319
Update MUR search results display #5319
Conversation
@JonellaCulmer I updated the search results display as discussed:
|
@patphongs Here are my followup comments: |
@JonellaCulmer Thanks for your follow-up comments. I have tightened up the spacing in the 3 areas that you spotted above. Please take a look to see if that's better. |
Codecov Report
@@ Coverage Diff @@
## develop #5319 +/- ##
========================================
Coverage 75.07% 75.07%
========================================
Files 125 125
Lines 8131 8131
Branches 648 648
========================================
Hits 6104 6104
Misses 2027 2027 Continue to review full report at Codecov.
|
@rfultz Thanks for the suggestion! I've added the word break for medium widths.
I think this is an artifact of all of our datatables. There's a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for everything, Pat!
Summary
Update MUR search results display with:
Required reviewers
1 front-end and 1 UX
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
How to test
npm run build-sass