Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wagtail to 2.15.4 #5148

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Upgrade wagtail to 2.15.4 #5148

merged 3 commits into from
Apr 12, 2022

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Apr 5, 2022

Summary

Upgrade wagtail to 2.15.4

Please check these upgrade-considerations notes and see if anything needs attention and add to "Items to check" list below.

Items to check from all upgrade considerations above:


Some new features/changes since 2.11.9:

###Related issues:
QA ticket: #5132

Required reviewers

Two frontend, QA ticket done by content team

Impacted areas of the application

modified: ../requirements.txt

Screenshots

Screen Shot 2022-04-05 at 1 12 50 PM


How to test

This has been merged to dev for Content team to test: https://dev.fec.gov/admin , QA ticket: #5132

Will be merged by 04/12 so further testing can take place on dev/stage

Before merging:

  • Get latest database dump for Wagtail database
  • Remove feature deploy task in tasks. py before merging

Test:

  • checkout branch and pip install -r requirements.txt
  • cd fec, ./manage.py migrate
  • test Wagtail admin, creating pages, uploading images, documents
  • test editing existing pages
  • does anything look awry in the admin ?

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #5148 (615dc1c) into develop (e57c821) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5148   +/-   ##
========================================
  Coverage    74.93%   74.93%           
========================================
  Files          125      125           
  Lines         8120     8120           
  Branches       648      648           
========================================
  Hits          6085     6085           
  Misses        2035     2035           
Impacted Files Coverage Δ
fec/home/models.py 88.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57c821...615dc1c. Read the comment docs.

@kathycarothers
Copy link
Contributor

I was not able to test the admin part. I did test creating a new page, adding a document, adding buttons etc. When I tried to add a picture it showed it was there, but the picture did not come up. It might be because I choose an old picture in feature. All seemed to be working well. @johnnyporkchops

@johnnyporkchops
Copy link
Contributor Author

Thanks for your quick review @kathycarothers. I don't think we'll see the images in feature b/c it's not mapped to an S3.
cc: @patphongs is that correct?

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnnyporkchops Everything looks good with the upgrade. The only thing that we discussed was changing the MeetingPage.imported_html model to use StreamFieldPanel to get rid of the warning. Even though that particular field we don't use, it would be better to not have a warning on migrations or app start up.

Also I don't believe we are using ElasticSearch, so we should be good there.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good to go, thanks @johnnyporkchops

Copy link
Contributor

@rfultz rfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM—haven't figured out how to break it

@rfultz rfultz merged commit 137183c into develop Apr 12, 2022
@rfultz rfultz deleted the feature/upgrade-wagtail-to-2.15.4 branch April 12, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Snyk: Low] wagtail Information Exposure (Due: 4/27/2022) Upgrade Wagtail to 2.15.4 LTS
5 participants