-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade wagtail to 2.15.4 #5148
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5148 +/- ##
========================================
Coverage 74.93% 74.93%
========================================
Files 125 125
Lines 8120 8120
Branches 648 648
========================================
Hits 6085 6085
Misses 2035 2035
Continue to review full report at Codecov.
|
I was not able to test the admin part. I did test creating a new page, adding a document, adding buttons etc. When I tried to add a picture it showed it was there, but the picture did not come up. It might be because I choose an old picture in feature. All seemed to be working well. @johnnyporkchops |
Thanks for your quick review @kathycarothers. I don't think we'll see the images in feature b/c it's not mapped to an S3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnnyporkchops Everything looks good with the upgrade. The only thing that we discussed was changing the MeetingPage.imported_html
model to use StreamFieldPanel
to get rid of the warning. Even though that particular field we don't use, it would be better to not have a warning on migrations or app start up.
Also I don't believe we are using ElasticSearch, so we should be good there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good to go, thanks @johnnyporkchops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM—haven't figured out how to break it
Summary
Upgrade wagtail to 2.15.4
Also resolves [Snyk: Low] wagtail Information Exposure (Due: 4/27/2022) #5043
Please check these upgrade-considerations notes and see if anything needs attention and add to "Items to check" list below.
Items to check from all upgrade considerations above:
Updated handling of non-required StreamFields
models.py
andblocks.py
Determine how/if we use wagtail search backend or elastic search?
Some new features/changes since 2.11.9:
stream_data
is now deprecated when we access streamfields in the Python shell( can usepage.body[0].block_type
orraw_data
https://docs.wagtail.org/en/stable/releases/2.12.html#stream-data-on-streamfield-values-is-deprecated
Would have to be enabled, not available in admin out of box. Possibly coming soon for Wagtail wishlist: Control column widths on table blocks #4258
###Related issues:
QA ticket: #5132
Required reviewers
Two frontend, QA ticket done by content team
Impacted areas of the application
modified: ../requirements.txt
Screenshots
How to test
This has been merged to dev for Content team to test: https://dev.fec.gov/admin , QA ticket: #5132
Will be merged by 04/12 so further testing can take place on dev/stage
Before merging:
tasks. py
before mergingTest:
pip install -r requirements.txt
cd fec
,./manage.py migrate