Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify PAC/Party datatable #4780

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Jul 20, 2021

Summary (required)

What's included:

  • Removes tooltips for PAC & party datatable for IE, Party, PACs, and filing frequency in filters and details panel
  • Removes tooltips for IE and PACs from the committees datatable
  • Retains tooltip for Ending cash on hand in details panel
  • Adds leadership PAC sponsor field to the details panel

Required reviewers

1 front end & 1 UX

Impacted areas of the application

General components of the application that this PR will affect:

Screenshots

Screen Shot 2021-07-20 at 11 58 44 AM

How to test

…ty, Filing frequency filters and details panel
Copy link
Contributor

@rfultz rfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo! LGTM!

Comment on lines +32 to +34
{{#panelRow "Filing frequency"}}
{{ filing_frequency_full }}
{{/panelRow}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow—saved a ton of code!

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @patphongs

@JonellaCulmer JonellaCulmer merged commit 99066b6 into develop Jul 20, 2021
@lbeaufort lbeaufort deleted the feature/4690-4769-mod-tooltips-add-sponsor branch October 20, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants