Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist nesting #413

Merged
merged 5 commits into from
Jul 29, 2016
Merged

Checklist nesting #413

merged 5 commits into from
Jul 29, 2016

Conversation

emileighoutlaw
Copy link
Contributor

Makes hierarchical improvements to checklist content. Clarifies relationships of parent and child pages.

Resolves: https://github.com/18F/fec-cms/issues/408#issuecomment-235633285

@codecov-io
Copy link

codecov-io commented Jul 27, 2016

Current coverage is 90.17% (diff: 100%)

Merging #413 into develop will not change coverage

@@            develop       #413   diff @@
==========================================
  Files             4          4          
  Lines           224        224          
  Methods          38         38          
  Messages          0          0          
  Branches         34         34          
==========================================
  Hits            202        202          
  Misses           22         22          
  Partials          0          0          

Powered by Codecov. Last update 4177784...83bf84e

@noahmanger
Copy link

Nice! Just made a small change: when you're nesting a <ul> inside another <ul> it should be in one of the <li> elements. So:

<ul>
  <li>item</li>
  <li>items:
    <ul>
      <li>item</li>
      <li>item</li>
     </ul>
   </li>
</ul>

@noahmanger noahmanger merged commit 3c74ff5 into develop Jul 29, 2016
@noahmanger noahmanger deleted the checklist-nesting branch July 29, 2016 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants