Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]3943 statistical data summary tables #4079

Closed
wants to merge 21 commits into from

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Sep 28, 2020

Summary

Impacted areas of the application

new_file: fec/static/js/pages/statistical-summary.js
modified: fec/home/models.py
new_file: fec/home/migrations/0110_auto_20200921_0151.py
modified: fec/home/templates/home/custom_page.html
modified: fec/static/scss/components/_table-styles.scss

Please ignore updated requirements.txt and tasks.py., those will ultimately not be part of the PR

Screenshots

  • Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface or front-end change, include both Before and After screenshots.

Related PRs

List related PRs against other branches:

branch PR
fix/other_pr link
feature/other_pr link

How to test

Include any information that may be helpful to the reviewer(s).
This might include:

  • links to sample pages to test
  • Any local environmental setup that is unusual (env vars, API version to point to, etc)

@JonellaCulmer
Copy link
Contributor

@johnnyporkchops I took a look at a few of the pages. Here is an annotated screenshot with comments:
Screen Shot 2020-09-29 at 1 28 00 PM

@johnnyporkchops
Copy link
Contributor Author

@JonellaCulmer Can you clarify for me an example of a press release link

@johnnyporkchops
Copy link
Contributor Author

Closing in favor of
#4088

@johnnyporkchops
Copy link
Contributor Author

I am re-opening this WIP PR to push latest changes to feature. Because my non-WIP branch has a different Django migration file, pushing that to feature causes conflicts. Normally the solution would be to restore feature database to latest dump and push the new branch...BUT, I have prototyped Wagtail pages there I do not want to overwrite!

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@0c5467b). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4079   +/-   ##
==========================================
  Coverage           ?   75.44%           
==========================================
  Files              ?      121           
  Lines              ?     7408           
  Branches           ?      596           
==========================================
  Hits               ?     5589           
  Misses             ?     1819           
  Partials           ?        0           
Impacted Files Coverage Δ
fec/home/models.py 87.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5467b...4b238d0. Read the comment docs.

@pkfec pkfec deleted the feature/3943-stat-summary-tables branch January 26, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement filterable campaign finance data summaries
5 participants