-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]3943 statistical data summary tables #4079
Conversation
…for feature deploy
…/fecgov/fec-cms into feature/3943-stat-summary-tables
@johnnyporkchops I took a look at a few of the pages. Here is an annotated screenshot with comments: |
@JonellaCulmer Can you clarify for me an example of a press release link |
Closing in favor of |
I am re-opening this WIP PR to push latest changes to feature. Because my non-WIP branch has a different Django migration file, pushing that to feature causes conflicts. Normally the solution would be to restore feature database to latest dump and push the new branch...BUT, I have prototyped Wagtail pages there I do not want to overwrite! |
Codecov Report
@@ Coverage Diff @@
## develop #4079 +/- ##
==========================================
Coverage ? 75.44%
==========================================
Files ? 121
Lines ? 7408
Branches ? 596
==========================================
Hits ? 5589
Misses ? 1819
Partials ? 0
Continue to review full report at Codecov.
|
Summary
Include a summary of proposed changes.
Impacted areas of the application
new_file: fec/static/js/pages/statistical-summary.js
modified: fec/home/models.py
new_file: fec/home/migrations/0110_auto_20200921_0151.py
modified: fec/home/templates/home/custom_page.html
modified: fec/static/scss/components/_table-styles.scss
Please ignore updated requirements.txt and tasks.py., those will ultimately not be part of the PR
Screenshots
Related PRs
List related PRs against other branches:
How to test
Include any information that may be helpful to the reviewer(s).
This might include: