Updated the language for no search results found #3829
Conversation
There was a problem hiding this comment.
@rfultz The screenshot looks fine. When I tested in dev, I got the old message.
|
@dorothyyeager the changes won't show up on |
| <p>If you'd like to contact our team, we're available by <a href="mailto:{{ settings.WEBMANAGER_EMAIL }}">email</a> or <a href="https://github.com/fecgov/fec">GitHub</a>.</p> | ||
| <p>Think this was a mistake?<br>Try one of the other search tools or submit feedback</p> | ||
| <p> | ||
| <a href="mailto:{{ settings.WEBMANAGER_EMAIL }}" class="button--standard">Email our team</a> <a href="https://github.com/fecgov/fec" class="button--standard">File an issue</a></p> |
There was a problem hiding this comment.
Should "File an issue" link to https://github.com/fecgov/fec/issues/new or https://github.com/fecgov/fec/issues?
It looks like we're linking to either one of those in other places. We should probably keep all of them consistent. https://github.com/fecgov/fec/issues/new seems like it might be friendliest.
There was a problem hiding this comment.
That wasn't specified so I left it as it was, but I've updated it to new issues
Codecov Report
@@ Coverage Diff @@
## develop #3829 +/- ##
========================================
Coverage 75.25% 75.25%
========================================
Files 121 121
Lines 7352 7352
Branches 592 592
========================================
Hits 5533 5533
Misses 1819 1819 Continue to review full report at Codecov.
|
Co-authored-by: Jonella <[email protected]>
Summary
Updated the message for when no search results are found:
Impacted areas of the application
Changed the language on the search results page when nothing is found
Screenshots
Current:
Updated:
Related PRs
None
How to test
Not sure who should test so I added a few of you. Feel free to bail or swap. Dorothy, I figured you can approve with the screenshot and/or dev
npm inpm run build/manage.py runserver