Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sitemaps for mvp #3614

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Conversation

jason-upchurch
Copy link
Contributor

Summary (required)

Impacted areas of the application

  • guidance doc search

@jason-upchurch jason-upchurch added the Guidance Search Work associated with Executive Order requiring Policy and Guidance search page label Mar 15, 2020
@jason-upchurch jason-upchurch added this to the Sprint 11.6 milestone Mar 15, 2020
@jason-upchurch jason-upchurch self-assigned this Mar 15, 2020
@jason-upchurch
Copy link
Contributor Author

jason-upchurch commented Mar 15, 2020

@dorothyyeager @patphongs cc @AmyKort @PaulClark2 my portion of the MVP is ready for review (added Dorothy and Pat as reviewers on the sitemap. Dorothy might check the list matches what is needed, and perhaps Pat can do a technical review?).

example search showing that only the guidance docs are returned in search, to include pdf and html.

https://search.usa.gov/search?utf8=%E2%9C%93&affiliate=fec_content_s3&sort_by=&query=legal&commit=Search

cc @pkfec @JonellaCulmer

Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing one URL from the list - please add https://webforms.fec.gov/wfja/form99

One question - instead of the https://fec-prod-proxy.app.cloud.gov part of the adddress for the pdf files, shouldn't it be https://www.fec.gov/? cc: @patphongs (If yes, please replace.)

@jason-upchurch
Copy link
Contributor Author

Missing one URL from the list - please add https://webforms.fec.gov/wfja/form99

One question - instead of the https://fec-prod-proxy.app.cloud.gov part of the adddress for the pdf files, shouldn't it be https://www.fec.gov/? cc: @patphongs (If yes, please replace.)

@dorothyyeager thank you, I will add that one! It may take time because of the additional domain, but will confirm. For the MVP I do not suggest we change the proxy to fec.gov domain. I suggest we work with search.gov to implement this in the second issue as a refinement (cc @patphongs)

@jason-upchurch
Copy link
Contributor Author

Missing one URL from the list - please add https://webforms.fec.gov/wfja/form99

One question - instead of the https://fec-prod-proxy.app.cloud.gov part of the adddress for the pdf files, shouldn't it be https://www.fec.gov/? cc: @patphongs (If yes, please replace.)

@patphongs Can we double check that url @dorothyyeager is providing? I don't think we want the top level domain in the search. Should it be "https://www.fec.gov/updates/"?

@jason-upchurch jason-upchurch force-pushed the feature/3599-guidance-doc-mvp branch from 657374a to a4c96df Compare March 16, 2020 17:13
@patphongs
Copy link
Member

@jason-upchurch @dorothyyeager I think this would satisfy the MVP for now, in terms of making both HTML and PDF pages indexable using search.gov. We need to think more about the domain strategy. We don't want to use the proxy domain, but let's think about what we can use on the fec.gov domain instead, it could be subdomain

@jason-upchurch jason-upchurch requested a review from patphongs April 7, 2020 13:11
@JonellaCulmer JonellaCulmer removed this from the Sprint 11.6 milestone Apr 7, 2020
@jason-upchurch jason-upchurch added this to the Sprint 12.1 milestone Apr 7, 2020
@jason-upchurch jason-upchurch force-pushed the feature/3599-guidance-doc-mvp branch from a4c96df to cd91c82 Compare April 7, 2020 19:45
@codecov-io
Copy link

Codecov Report

Merging #3614 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3614   +/-   ##
========================================
  Coverage    74.91%   74.91%           
========================================
  Files          120      120           
  Lines         7398     7398           
  Branches       652      652           
========================================
  Hits          5542     5542           
  Misses        1856     1856           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2d9a1...cd91c82. Read the comment docs.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @jason-upchurch, thank you!

Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @jason-upchurch

@dorothyyeager dorothyyeager merged commit e786fe8 into develop Apr 7, 2020
@dorothyyeager dorothyyeager deleted the feature/3599-guidance-doc-mvp branch April 7, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guidance Search Work associated with Executive Order requiring Policy and Guidance search page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guidance doc search MVP
5 participants