-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sitemaps for mvp #3614
add sitemaps for mvp #3614
Conversation
@dorothyyeager @patphongs cc @AmyKort @PaulClark2 my portion of the MVP is ready for review (added Dorothy and Pat as reviewers on the sitemap. Dorothy might check the list matches what is needed, and perhaps Pat can do a technical review?). example search showing that only the guidance docs are returned in search, to include pdf and html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing one URL from the list - please add https://webforms.fec.gov/wfja/form99
One question - instead of the https://fec-prod-proxy.app.cloud.gov part of the adddress for the pdf files, shouldn't it be https://www.fec.gov/? cc: @patphongs (If yes, please replace.)
@dorothyyeager thank you, I will add that one! It may take time because of the additional domain, but will confirm. For the MVP I do not suggest we change the proxy to fec.gov domain. I suggest we work with search.gov to implement this in the second issue as a refinement (cc @patphongs) |
@patphongs Can we double check that url @dorothyyeager is providing? I don't think we want the top level domain in the search. Should it be "https://www.fec.gov/updates/"? |
657374a
to
a4c96df
Compare
@jason-upchurch @dorothyyeager I think this would satisfy the MVP for now, in terms of making both HTML and PDF pages indexable using search.gov. We need to think more about the domain strategy. We don't want to use the proxy domain, but let's think about what we can use on the fec.gov domain instead, it could be subdomain |
a4c96df
to
cd91c82
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3614 +/- ##
========================================
Coverage 74.91% 74.91%
========================================
Files 120 120
Lines 7398 7398
Branches 652 652
========================================
Hits 5542 5542
Misses 1856 1856 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good @jason-upchurch, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @jason-upchurch
Summary (required)
Impacted areas of the application