[DO NOT MERGE] Feature/3509 presidential map 2 #3569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Only present and positioned—not styled, not sized, not stacked)
…ec-cms into feature/3509-presidential-map-2
…ds area--always scrollTo
|
This PR/branch show bubbles and some of the state click behavior (data switch, downloads switch) but not the visual state change yet. |
|
Closing this issue. Tracking the changes in this branch : feature/3517-presidential-map-3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The bubbles/circles are in and working, though not styled well. They're clickable but don't really do anything. Also, rolling over them or the state fills will change their layers; I'll deal with that during #3517
Impacted areas of the application
This map AND WCCF - DO NOT MERGE
Screenshots
The circles in place (with a black stroke applied)
Related PRs
How to test
Pull, build, and run as usual. The circles should appear when the map style is changed from gradient to bubbles. The circles should change as the election year is changed, too—though most values will remain in the same ranges.