Add feature flag, silence JS tests, address some feedback for presidential map #3556
Conversation
lbeaufort
changed the base branch from
develop
to
feature/3514-presidential-map-1
lbeaufort
changed the title
lbeaufort
changed the title
lbeaufort
changed the title
Codecov Report
@@ Coverage Diff @@
## feature/3514-presidential-map-1 #3556 +/- ##
==================================================================
Coverage ? 74.94%
==================================================================
Files ? 120
Lines ? 7383
Branches ? 642
==================================================================
Hits ? 5533
Misses ? 1850
Partials ? 0
Continue to review full report at Codecov.
|
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| from data import views | |||
| from data import views_datatables | |||
| from fec import settings | |||
There was a problem hiding this comment.
Nice! This will let us turn on/off other URLs through feature flags, too
| const openDownloads = function(){ | ||
| console.log('callback') | ||
|
|
||
| const openDownloads = function() { |
There was a problem hiding this comment.
Will probably make this more specific to the PresFinMap rather than global to avoid other possible conflicts, but we can get to that for or after launch
| @@ -1,3 +1,5 @@ | |||
| /* eslint-disable no-undef */ | |||
There was a problem hiding this comment.
Just noting that this is only to get things on dev and should not go into production
There was a problem hiding this comment.
@rfultz agreed that it seems prone to human error if we forgot to remove it - if you'd rather address the errors individually, feel free to commit here or on another iteration!
| /* eslint-disable no-undef */ | ||
| /* eslint-disable no-unused-vars */ |
There was a problem hiding this comment.
Just noting that these are only to get things on dev and should not go into production
| hT = instance.downloadsWrapper.getBoundingClientRect().top + wS, | ||
| hH = instance.downloadsWrapper.offsetHeight, | ||
| wH = window.innerHeight; | ||
| if (wS > hT + hH - wH) { |
There was a problem hiding this comment.
Would like to name these vars more human-friendly but no biggie for now
| @@ -1309,3 +1312,6 @@ function logUsage(candID, electionYear) { | |||
| } | |||
|
|
|||
| new PresidentialFundsMap(); | |||
|
|
|||
| /* eslint-enable no-undef */ | |||
| /* eslint-enable no-unused-vars */ | |||
There was a problem hiding this comment.
Linter may require a blank line at the end. 🤞
constants.states_excl_territoriesfor state list per Feature/3514 presidential map 1 #3547 (comment)Feature flag info
To turn on the feature,
export FEC_FEATURE_PRESIDENTIAL_MAP=TrueTo turn it off,
unset FEC_FEATURE_PRESIDENTIAL_MAPYou may want to add it to your bash profile so that you don't have to keep setting it.