-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update F3X to F24 when 24- and 48-Hour Reports selected #3531
Conversation
@patphongs Looks good. A couple changes that I noticed. We should change the text from "Regularly scheduled report form" to just "Report form" since 24- and 48-reports aren't regularly scheduled. Can we also remove the dividing line between the two filters? Since they work together a bit. |
…e and report form
@JonellaCulmer These changes have been applied, can you please check and test again? Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #3531 +/- ##
===========================================
+ Coverage 74.96% 74.97% +0.01%
===========================================
Files 120 120
Lines 7377 7381 +4
Branches 642 644 +2
===========================================
+ Hits 5530 5534 +4
Misses 1847 1847
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks, @patphongs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @patphongs!
Summary (required)
Update the regularly scheduled report form from F3X to F24 when 24- and 48-Hour Reports are selected.
Impacted areas of the application
List general components of the application that this PR will affect:
Screenshots
-No screenshots, just modified fetch call._
How to test
24- and 48-Hour Report
selected.filing_form=F24
.Regularly scheduled reports
selected.filing_form=F3X
.