Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update F3X to F24 when 24- and 48-Hour Reports selected #3531

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

patphongs
Copy link
Member

Summary (required)

Impacted areas of the application

List general components of the application that this PR will affect:

Screenshots

-No screenshots, just modified fetch call._

How to test

  • Checkout this branch
  • npm run build
  • Go to the IE datatable: http://localhost:8000/data/independent-expenditures/
  • Check the Form 3X checkbox under Regularly scheduled report form. Make sure to leave Report type toggle with the 24- and 48-Hour Report selected.
  • Check the AJAX call in the console to make sure that it's querying for filing_form=F24.
  • Change the Report type toggle to have Regularly scheduled reports selected.
  • Check the AJAX call in the console to make sure that it's querying for filing_form=F3X.

@patphongs patphongs changed the title Feature/3463 update f3x to f24 Update F3X to F24 when 24- and 48-Hour Reports selected Feb 7, 2020
@JonellaCulmer
Copy link
Contributor

@patphongs Looks good. A couple changes that I noticed. We should change the text from "Regularly scheduled report form" to just "Report form" since 24- and 48-reports aren't regularly scheduled. Can we also remove the dividing line between the two filters? Since they work together a bit.

@patphongs
Copy link
Member Author

A couple changes that I noticed. We should change the text from "Regularly scheduled report form" to just "Report form" since 24- and 48-reports aren't regularly scheduled. Can we also remove the dividing line between the two filters? Since they work together a bit.

@JonellaCulmer These changes have been applied, can you please check and test again? Thanks!

@codecov-io
Copy link

Codecov Report

Merging #3531 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3531      +/-   ##
===========================================
+ Coverage    74.96%   74.97%   +0.01%     
===========================================
  Files          120      120              
  Lines         7377     7381       +4     
  Branches       642      644       +2     
===========================================
+ Hits          5530     5534       +4     
  Misses        1847     1847
Impacted Files Coverage Δ
fec/fec/static/js/modules/tables.js 53.33% <100%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7946880...ad8383c. Read the comment docs.

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @patphongs

@patphongs patphongs removed the request for review from rfultz February 13, 2020 14:54
Copy link
Member

@lbeaufort lbeaufort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @patphongs!

@lbeaufort lbeaufort merged commit b2797d5 into develop Feb 13, 2020
@lbeaufort lbeaufort deleted the feature/3463-update-f3x-to-f24 branch February 13, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Form 24 data when Form 3X is selected for 24/48 hour notices
4 participants