Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for global site search #3278

Merged
merged 7 commits into from
Oct 22, 2019
Merged

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Oct 18, 2019

Summary

Reindexing has already been completed on the website using search.gov and our custom indexing scripts. Followed documentation based on what was written here: https://github.com/fecgov/fec-cms/blob/develop/fec/search/management/instructions.md

The transition drawer did not exist in our search.gov interface, therefore, I removed it from the site index commands.

Impacted areas of the application

List general components of the application that this PR will affect:

  • Global search on site's header

How to test

  • Re-activate your account on the rebranded search.gov. If you have not logged into search.gov for more than 90 days, your account has been deactivated. You'll need to email [email protected]
  • Login to search.gov and look around
  • Get a fresh dump of the wagtail CMS database and update your CMS DB on your local machine.
  • Follow documentation under this branch: https://github.com/fecgov/fec-cms/blob/feature/2991-global-site-search/fec/search/management/instructions.md to understand how scraping and indexing works
  • Attempt to run scrape and index commands using this branch
  • Take a look at the main drawer referenced in the documentation. If an index has been done, it will push it to the search.gov main drawer and it should say that it has been updated recently.

@patphongs patphongs requested a review from lbeaufort October 18, 2019 14:35
@codecov-io
Copy link

Codecov Report

Merging #3278 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3278   +/-   ##
=======================================
  Coverage     74.6%   74.6%           
=======================================
  Files          120     120           
  Lines         7194    7194           
  Branches       633     633           
=======================================
  Hits          5367    5367           
  Misses        1827    1827
Impacted Files Coverage Δ
fec/fec/constants.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4739775...c5742ee. Read the comment docs.

@lbeaufort
Copy link
Member

@patphongs the search.gov team said they reactivated my account on Friday but I'm not able to log in. I sent them another email and I'm waiting to hear back.

@lbeaufort
Copy link
Member

Follow-up issues:
#3283
#3286
#3287

Copy link
Member

@lbeaufort lbeaufort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @patphongs!! I entered follow-up issues for things we discussed.

@patphongs
Copy link
Member Author

This has been approved, merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reindex site results with search.gov
3 participants