Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3216 wccf map colors #3229

Merged
merged 5 commits into from
Oct 4, 2019
Merged

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Oct 4, 2019

Summary

Impacted areas of the application

All of the changes are contained inside WCCF.

Screenshots

image

Related PRs

List related PRs against other branches:

branch PR
feature/3204-wccf-indiv-contribs-btn #3204 (related, not dependent)

How to test

  • Pull, build, and run like normal (FEC_FEATURE_CONTRIBUTIONS_BY_STATE must be true)
  • Change candidates and test values.
    • Warren, Elizabeth (Senate) will default to 2024 and offer all $0s. 2018 has data.
    • San Nicolas, Michael (House) has only a few values.
    • Perot (President) has a few $0s.
    • Mondale (President) has low numbers
    • Obama (President, 2008) has the highest numbers to date

Note: The color scale is based on the value of the state with the lowest value + 50% of the range between the lowest and highest states. The goal was to skew the scale so the 2-4 highest-raising (and highest population) states—more like showing the mode average more than the median average.


@codecov-io
Copy link

Codecov Report

Merging #3229 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3229   +/-   ##
=======================================
  Coverage     74.6%   74.6%           
=======================================
  Files          120     120           
  Lines         7160    7160           
  Branches       633     633           
=======================================
  Hits          5342    5342           
  Misses        1818    1818

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7192d...7b1f92c. Read the comment docs.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rfultz! Colors and legend look good

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the colors appear to line up and the amounts fit appropriately within the define buckets.

@patphongs patphongs merged commit ae2819c into develop Oct 4, 2019
@lbeaufort lbeaufort deleted the feature/3216-wccf-map-colors branch October 7, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple election year in URL from Where contributions come from Update key to match colors displayed in map
4 participants