Add other filers button to h4cc landing page #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/public-20190205 #2660 +/- ##
==========================================================
+ Coverage 74.72% 74.8% +0.07%
==========================================================
Files 116 116
Lines 7024 7024
Branches 600 600
==========================================================
+ Hits 5249 5254 +5
+ Misses 1775 1770 -5
Continue to review full report at Codecov.
|
rfultz
approved these changes
Feb 5, 2019
| @@ -35,7 +35,7 @@ <h2>Guides</h2> | |||
| <a href="/help-candidates-and-committees/guides/?tab=political-party-committees"> | |||
| <aside class="card card--horizontal card--secondary"> | |||
| <div class="card__image__container"> | |||
| <span class="card__icon i-notebook"><span class="u-visually-hidden">Icon of a training screen</span></span> | |||
| <span class="card__icon i-notebook"><span class="u-visually-hidden">Icon representing a notebook</span></span> | |||
There was a problem hiding this comment.
I love that we're paying attention to labels, alt tags, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the other filers ticket here: #2222 (comment), we needed to add the other filers button to the Help for candidates and committees landing page.
Test on this page: http://localhost:8000/help-candidates-and-committees/
Impacted areas of the application
List general components of the application that this PR will affect:
Screenshots