Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setTimout function-elections map #2507

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

johnnyporkchops
Copy link
Contributor

Summary

Remove setTimeout function so zipcode zoom/color works properly
The setTimout error was added to remove console error, but then causes problems with the zipcode search function.( There exists a console error on production, so this still represents a step forward and the current console error will be researched.)

Impacted areas of the application

modified: fec/static/js/modules/election-map.js

How to test

  • Checkout and run this branch locally: feature/fix-districts-map-zoom
  • npm run build
  • go to http://127.0.0.1:8000/data/elections/ and select states and districts, then enter a zipcode and see that it zooms to that zipcode with district colored.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnnyporkchops, the zipcode zoom now zooms correctly on the corresponding district(s). Merging...

@patphongs patphongs merged commit 9fd1130 into develop Nov 13, 2018
@lbeaufort lbeaufort deleted the feature/fix-districts-map-zoom branch November 16, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants