[MERGE WITH GIT FLOW] Fix candidate filing pages for missing amendment chain #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patphongs
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
amendment_chain that is null is now working. Thanks @lbeaufort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Fix candidate filing pages for missing amendment chain. In rare occasions like this filing, a F99 will get coded as a F2 and won't have an amendment chain. This PR checks for an amendment chain before trying to check its length.
Impacted areas of the application
List general components of the application that this PR will affect:
Screenshots
Before
After
Related PRs
#2410
How to test
Filings should load:
http://localhost:8000/data/candidate/P80001571/?tab=filings
http://localhost:8000/data/filings/?data_type=processed&candidate_id=P80001571