Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement data table descriptions #2495

Merged

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Nov 7, 2018

Summary

Add datatable descriptions and glossary links(where applicable) to adv data page templates

Impacted areas of the application

modified: data/templates/partials/advanced/filings-reports.jinja
modified: data/templates/partials/advanced/loans-debts.jinja
modified: data/templates/partials/advanced/raising.jinja
modified: data/templates/partials/advanced/spending.jinja

How to test

@JonellaCulmer
Copy link
Contributor

@johnnyporkchops Everything is great except for the two places where we link to the glossary. They're not linked to the correct terms and so the glossary opens, but there's nothing there.
Electioneering communications should link to "Electioneering communication" in the glossary.
Party coordinated expenditures should link to "Coordinated party expenditure" in the glossary.

@johnnyporkchops
Copy link
Contributor Author

@JonellaCulmer , I fixed the glossary links. I was inadvertently testing the existing links, not the two new ones.

@codecov-io
Copy link

Codecov Report

Merging #2495 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2495   +/-   ##
========================================
  Coverage    74.39%   74.39%           
========================================
  Files          112      112           
  Lines         6867     6867           
  Branches       598      598           
========================================
  Hits          5109     5109           
  Misses        1758     1758

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fbe50b...91f2555. Read the comment docs.

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Thanks, @johnnyporkchops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants