Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort nulls last in data tables #2491

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Nov 5, 2018

Summary (required)

Because we can't know where null values belong, we should always sort nulls last (at the bottom, on the last pages) in data tables.

Impacted areas of the application, how to test

List general components of the application that this PR will affect:

@lbeaufort
Copy link
Member Author

@johnnyporkchops the API change has been merged, so this is ready when you have a chance. Thank you!

@lbeaufort lbeaufort changed the base branch from develop to master November 7, 2018 22:50
@lbeaufort lbeaufort changed the base branch from master to develop November 7, 2018 22:50
@lbeaufort lbeaufort added this to the Sprint 7.5 milestone Nov 7, 2018
@lbeaufort lbeaufort changed the title [MERGE AFTER API CHANGE] Sort nulls last in data tables Sort nulls last in data tables Nov 8, 2018
Copy link
Contributor

@johnnyporkchops johnnyporkchops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected

@johnnyporkchops johnnyporkchops merged commit 4b19c75 into develop Nov 8, 2018
@lbeaufort lbeaufort deleted the feature/sort-nulls-last branch November 16, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants