Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/fix candidate profiles #2299

Closed
wants to merge 4 commits into from

Conversation

lbeaufort
Copy link
Member

  • Figure out Trump 2012/1988 raising/spending bug

Summary (required)

Impacted areas of the application

List general components of the application that this PR will affect:

Screenshots

  • Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface or front end change, include both a Before and After screenshot.

Related PRs

List related PRs against other branches:

branch PR
fix/other_pr link
feature/other_pr link

IF ANY OF THE ABOVE FIELDS DO NOT APPLY, PLEASE DELETE THEM BEFORE SUBMITTING

@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #2299 into develop will increase coverage by 1.28%.
The diff coverage is 86.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2299      +/-   ##
===========================================
+ Coverage    72.65%   73.93%   +1.28%     
===========================================
  Files          111      112       +1     
  Lines         6499     6500       +1     
  Branches       805      798       -7     
===========================================
+ Hits          4722     4806      +84     
+ Misses        1739     1642      -97     
- Partials        38       52      +14
Impacted Files Coverage Δ
fec/data/urls.py 100% <ø> (ø) ⬆️
fec/data/tests/test_cand_cmte_pages.py 100% <100%> (ø)
fec/data/views.py 32% <76.19%> (+17.71%) ⬆️
fec/fec/static/js/modules/calendar.js 91.24% <0%> (-0.73%) ⬇️
fec/fec/static/js/modules/toc.js 100% <0%> (+2.56%) ⬆️
fec/data/templatetags/filters.py 72.09% <0%> (+9.3%) ⬆️
fec/data/utils.py 54.2% <0%> (+9.34%) ⬆️
fec/data/api_caller.py 43.45% <0%> (+11.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457c381...cf28edd. Read the comment docs.

@lbeaufort lbeaufort changed the title [WIP ]Feature/fix candidate profiles [WIP] Feature/fix candidate profiles Aug 23, 2018
@lbeaufort
Copy link
Member Author

Closing in favor of #2316

@lbeaufort lbeaufort closed this Aug 28, 2018
@lbeaufort lbeaufort deleted the feature/fix-candidate-profiles branch September 13, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 Errors when clicking through to individual candidate/committee pages
2 participants