-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react and dependencies to v16.4.2 #2292
Conversation
This PR is contingent on testing for React on feature: #2307. This testing will be completed on 9/6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally in a few page types and draftail editor works as expected. I am getting a console error that seems to occur locally whenever ../package-lock.json
is changed in a branch--so I don't think its related to any of the React upgrades here, but just flagging in case. If no one deems this an issue, I can approve and merge.
Upgrade React to newest version to support new Draftail features.
Impacted areas of the application
To Do
react
,react-dom
, and any other dependenciesenzyme
andkarma
JS testing dependencies