Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react and dependencies to v16.4.2 #2292

Merged
merged 3 commits into from
Sep 10, 2018

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Aug 17, 2018

Upgrade React to newest version to support new Draftail features.

Impacted areas of the application

To Do

  • Upgrade react, react-dom, and any other dependencies
  • Upgrade enzyme and karma JS testing dependencies
  • Check functionality on the Wagtail Draftail Editor and functionality of https://www.fec.gov/legal-resources/

@patphongs
Copy link
Member

This PR is contingent on testing for React on feature: #2307. This testing will be completed on 9/6.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apburnes This is looking good, testing has been completed for React 16. The only extra thing that needs to be added to this PR is the polyfil for IE that you implemented on the feature branch PR: #2298

@patphongs patphongs mentioned this pull request Sep 6, 2018
2 tasks
Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!

Copy link
Contributor

@johnnyporkchops johnnyporkchops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in a few page types and draftail editor works as expected. I am getting a console error that seems to occur locally whenever ../package-lock.json is changed in a branch--so I don't think its related to any of the React upgrades here, but just flagging in case. If no one deems this an issue, I can approve and merge.

@johnnyporkchops johnnyporkchops merged commit fdd0ea4 into develop Sep 10, 2018
@lbeaufort lbeaufort deleted the feature/upgrade-react branch September 13, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add polyfills to React 16 update to support IE customers Upgrade to latest version of React v16.x
3 participants