Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add AO citations #2171

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Re-add AO citations #2171

merged 1 commit into from
Jul 9, 2018

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Jul 9, 2018

This reverts commit 8ddb864 (git revert 8ddb86438b10e26c9aab6059bd1a29b66203fd91).

Summary (required)

Impacted areas of the application

List general components of the application that this PR will affect:

  • AO search and canonical page

Screenshots

screen shot 2018-07-09 at 10 21 49 am

screen shot 2018-07-09 at 10 22 05 am

Related PRs

List related PRs against other branches:

#2159

This reverts commit 8ddb864.
@patphongs
Copy link
Member

@lbeaufort I tested this AO: http://localhost:8000/data/legal/advisory-opinions/2016-26/ and the Legal citations show up as expected.

Then I tried the citation search filters. Regulatory citations worked, however, the Statutory citation filter search returns 500s. I'm not sure if this happened previously or something that just started happening. Here's an example of the API error when attempting to filter by statutory citation: https://fec-dev-api.app.cloud.gov/v1/legal/search/?type=advisory_opinions&ao_category=F&ao_statutory_citation=52+U.S.C.+%C2%A730101

@patphongs
Copy link
Member

Merging but added the statutory citation bug as a separate issue in the API: fecgov/openFEC#3271

@patphongs patphongs merged commit 92a1041 into develop Jul 9, 2018
@lbeaufort lbeaufort deleted the feature/put-back-ao-citations branch July 12, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants