[MERGE WITH GIT FLOW] Add mur_respondents filter to "next" and "previous" buttons
#1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes bug #1859 - Add `&mur_respondents={{mur_respondents}}` to MUR pagination links
johnnyporkchops
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
&mur_respondents={{mur_respondents}}to MUR pagination linksImpacted areas of the application
Screenshots
Before
Search "Nevada NOW" as MUR Respondent...
https://www.fec.gov/data/legal/search/murs/?search_type=murs&search=&mur_no=&mur_respondents=Nevada+NOW
then try to go to the next page. It resets your results:
After
Search "Nevada NOW" as MUR Respondent...
http://localhost:8000/data/legal/search/murs/?search_type=murs&search=&mur_no=&mur_respondents=Nevada+NOW
then try to go to the next page. You actually get to the next page:
Note I found a display problem but it's already in production. I'll enter a new bug if it's not already there.
https://www.fec.gov/data/legal/search/murs/?search=&mur_respondents=Nevada%20NOW&offset=20#results-murs
http://localhost:8000/data/legal/search/murs/?search=&mur_respondents=Nevada%20NOW&offset=20#results-murs