Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed scss for numbered lists and alternating-bg cards #1789

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Feb 14, 2018

Addresses:
add numbers to list--numbered class : https://github.com/18F/fec-cms/issues/1781
add transparent border to .card--alternating-bg : https://github.com/18F/fec-cms/issues/1734

Numbered lists:

numbered_lists

Alternating-bg cards before/after

Before:
jump

After:
no_jump

Copy link
Contributor

@jenniferthibault jenniferthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this locally and visually the styles look 👍💯

As per usual, I can't speak to the technical implication, so passing that on to @patphongs 💐

@codecov-io
Copy link

Codecov Report

Merging #1789 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1789   +/-   ##
========================================
  Coverage    79.39%   79.39%           
========================================
  Files           45       45           
  Lines         3261     3261           
  Branches       488      488           
========================================
  Hits          2589     2589           
  Misses         672      672

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8181542...93636e6. Read the comment docs.

@johnnyporkchops
Copy link
Contributor Author

Added the same styles for numbered lists to apply to html-blocks as well as rich-text blocks. That was the missing piece making testing this so confusing!

Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this John! I will leave the code review for those who know better what it should look like, but am glad to have this done!

@johnnyporkchops
Copy link
Contributor Author

See the even more offensive example of jumping in upadted screenshot above

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnnyporkchops, works well

@patphongs patphongs merged commit 68d956b into develop Feb 16, 2018
@johnnyporkchops johnnyporkchops deleted the feature/scss-fixes-1781-and-1734 branch February 20, 2018 23:17
@johnnyporkchops johnnyporkchops restored the feature/scss-fixes-1781-and-1734 branch February 20, 2018 23:20
@lbeaufort lbeaufort deleted the feature/scss-fixes-1781-and-1734 branch August 21, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants