Add Coverage end date to Source reports

[johnnyporkchops]

This PR addresses a few issues that are in grooming. It may be salvaged to implement an interim solution that is being discussed, if/when one is agreed upon. See issues referenced below for discussions:

• Addresses 1735 (in grooming)
• Addresses 1470 (Currently implemented solution)

Also these two OpenFEC PRs have been merged by @lbeaufort to accommodate possible solutions:
https://github.com/18F/openFEC/pull/2901- Add committee_pcc to /elections/ endpoint
https://github.com/18F/openFEC/pull/2898 -Add coverage end date to /elections/endpoint

Completion criteria, Issue 1470:

• change source reports link text from "view", to "View all"
• /elections/ EndPoint API needs to be modified to return coverage end date
• add handlebars template to handle this particular mullt-line/conditional content within datatable column

@hcaofec has done some research into backend changes that need to take place and may be of help.

Screenshots

[codecov-io]

Codecov Report

Merging #1701 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1701   +/-   ##
========================================
  Coverage    79.39%   79.39%           
========================================
  Files           45       45           
  Lines         3261     3261           
  Branches       488      488           
========================================
  Hits          2589     2589           
  Misses         672      672

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dfd27...357fa75. Read the comment docs.

[johnnyporkchops]

I took a first pass at changing the link in reports column to link to the location @paul mentioned here. https://github.com/18F/fec-cms/issues/1735

• [x ] I did not figure out how to link to PCC if there is more than one committee. Resolved-Laura added endpoint param for this,
  - [ ] One candidate does not show a committee ID in the link that is built. (Example: SHOEMAKER, FRANKLIN ED) Resolved: this was a mistake in data that i believe has been corrected

Since this is a priority, anyone feel free to push it forward (or redo it if I missed the mark), I think have taken it a far as I can without some pairing help. , cc @lbeaufort, @LindsayYoung.

[johnnyporkchops]

• Added the source reports coverage end date and language. Conditionally rendering the coverage_end_date or "No processed data this period."-- if no coverage_end_date.
• Created handlebars templates to render in column

[JonellaCulmer]

@johnnyporkchops What's the line height in the source reports column?

[patphongs]

@johnnyporkchops just a comment about the view all link

[patphongs]

If there is no processed data for this period, the link to the view all should not exist. I found that this becomes problematic if there is no committee connected to a candidate. When attempting to click on the view all, it will not filter anything because there is no committee connected to the candidate at all.

Can we move this {{#if url}} block into the `{{#if coverage_end_date }} block so that the link won't show up if there's no processed data?

This is currently a production bug too, so doing this would also fix that bug.

[johnnyporkchops]

@JonellaCulmer , line height on the td is 1.8, inherited. A similar example of multiline text in columns is the Version column on the reports datatables.

[patphongs]

Thanks for the change @johnnyporkchops, this looks good to me

[johnnyporkchops]

Thanks @patphongs . I was thinking I do not need the if url statement because there will always be a URL, but we can change that when/if we refine this for 1735

[johnnyporkchops]

@lbeaufort -- Is this an issue where this one candidate who does not return a committee ID in the URL that is built for this page?
The example page: https://www.fec.gov/data/elections/senate/FL/2018/
SHOEMAKER, FRANKLIN ED
The URL created: https://www.fec.gov/data/reports/house-senate/?committee_id&cycle=2018&is_amended=false
I think you said you had some insight into this when we discovered it while pairing on this task.