AO URL Fix #1410
Merged
AO URL Fix #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
======================================
Coverage 79.4% 79.4%
======================================
Files 46 46
Lines 3297 3297
Branches 497 497
======================================
Hits 2618 2618
Misses 679 679Continue to review full report at Codecov.
|
lbeaufort
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the merged CMS and Web app code, there is a reference to both URLs for AOs, one with a dash and one with an underscore. The underscore was incorrect. This was breaking our paths. Will also set a redirect in Wagtail for the version with underscores just in case.
Correct:
data/legal/advisory-opinions/data/legal/search/advisory-opinions/Incorrect:
data/legal/advisory_opinions/data/legal/search/advisory_opinions/