Fixed CSRF token not being available for Feedback form #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset fixes the missing CSRF token for the feedback form by rendering it directly in the templates instead of trying to leverage a cookie that is not being set.
Codecov Report
@@ Coverage Diff @@
## develop #1397 +/- ##
=========================================
- Coverage 79.49% 79.4% -0.1%
=========================================
Files 46 46
Lines 3297 3297
Branches 497 497
=========================================
- Hits 2621 2618 -3
- Misses 676 679 +3
Continue to review full report at Codecov.
|
ccostino
added a commit
that referenced
this pull request
Oct 26, 2017
This changeset addresses an issue with the Feedback form and a missing CSRF token. See PR #1397 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes the missing CSRF token for the feedback form by rendering it directly in the templates instead of trying to leverage a cookie that is not being set.