Fixes AO pagination #1383
Merged
Fixes AO pagination #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/public-20171011 #1383 +/- ##
========================================================
Coverage 79.49% 79.49%
========================================================
Files 46 46
Lines 3297 3297
Branches 497 497
========================================================
Hits 2621 2621
Misses 676 676Continue to review full report at Codecov.
|
xtine
suggested changes
Oct 25, 2017
| function interceptHandleChange(offset) { | ||
|
|
||
| // from_hit is a zero-based index | ||
| var updatedFromHit = props.from_hit + offset; |
There was a problem hiding this comment.
This is ES6, so I believe this needs to be let.
| } | ||
|
|
||
| // create an event to update from_hit | ||
| const syntheticEvent = { target: { name: 'from_hit', value: updatedFromHit } }; |
There was a problem hiding this comment.
Can you expand the object in a nested fashion for readability?
| var updatedFromHit = props.from_hit + offset; | ||
|
|
||
| // when from_hit is less than 0, reset to 0 (ensures no negative value) | ||
| if (updatedFromHit < 0){ |
There was a problem hiding this comment.
Space after ). I would recommend installing eslint or something similar.
xtine
approved these changes
Oct 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/18F/fec-cms/issues/1382
This sets the standard offset to 20 and accounts for boundaries in the from_hit value. This ensures no negative pages or pages that would go beyond the total result count.