-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and cloud.gov config to build with CircleCI #1253
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1253 +/- ##
========================================
Coverage 79.55% 79.55%
========================================
Files 46 46
Lines 3287 3287
Branches 495 495
========================================
Hits 2615 2615
Misses 672 672 Continue to review full report at Codecov.
|
…, will continue to test
Continuing to update CircleCI config in addition to a few other items: * nvm/Node.js setup * Removed .travis.yml config * Updated README.md * Updated against latest develop changes
I also noticed that at least the Python requirements were being listed as already installed, so we should not need to do that again at this step.
nvm use default | ||
cd fec | ||
./manage.py test | ||
npm run test-single |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xtine should this kick back up one directory before running the tests with npm
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm tasks still run without being in the root directory.
The URLs actually needed to stay as they were to allow the mock objects to register fake URLs to mimic the endpoints.
We're currently running into an issue where the locales available in the Python Docker image (and this is an issue in both the official Python Docker image as well as the CircleCI version) don't support currency formatting, which is used in one of our tests:
We're trying to figure out ways to solve this because unfortunately we cannot just switch locales to one that will work. The only available ones are |
I've commented out the failing test for now, I think it's safe to just get this working and then... circle back on fixing that (sorry!). Now I'm stuck on a Django |
Thank you @LindsayYoung for the help with that! |
Hmm, guess we should close this one in favor of PR #1270? |
This changeset removes the old Travis CI config in favor of the new CircleCI config.
It also removes the .python-version file from the repository for the time being. We were never able to move forward on the pip-tools install, so this is not needed at the moment and makes dealing with Python updates locally a bit more cumbersome at the moment. We can bring this back once we have a chance to work on Python dependency management a bit more and provide clear documentation on how to manage these things.
In the interim, if you are using pyenv to manage your local Python installations, please be sure you have a global version set, e.g., pyenv global 3.5.4.