Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and cloud.gov config to build with CircleCI #1253

Closed
wants to merge 39 commits into from

Conversation

LindsayYoung
Copy link
Contributor

@LindsayYoung LindsayYoung commented Sep 15, 2017

This changeset removes the old Travis CI config in favor of the new CircleCI config.

It also removes the .python-version file from the repository for the time being. We were never able to move forward on the pip-tools install, so this is not needed at the moment and makes dealing with Python updates locally a bit more cumbersome at the moment. We can bring this back once we have a chance to work on Python dependency management a bit more and provide clear documentation on how to manage these things.

In the interim, if you are using pyenv to manage your local Python installations, please be sure you have a global version set, e.g., pyenv global 3.5.4.

@codecov-io
Copy link

codecov-io commented Sep 15, 2017

Codecov Report

Merging #1253 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1253   +/-   ##
========================================
  Coverage    79.55%   79.55%           
========================================
  Files           46       46           
  Lines         3287     3287           
  Branches       495      495           
========================================
  Hits          2615     2615           
  Misses         672      672

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e33c8...fb1c53f. Read the comment docs.

@ccostino ccostino mentioned this pull request Sep 18, 2017
Continuing to update CircleCI config in addition to a few other items:

* nvm/Node.js setup
* Removed .travis.yml config
* Updated README.md
* Updated against latest develop changes
I also noticed that at least the Python requirements were being listed as already installed, so we should not need to do that again at this step.
@ccostino ccostino changed the title deploy with circle Update CI and cloud.gov config to build with CircleCI Sep 21, 2017
nvm use default
cd fec
./manage.py test
npm run test-single
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtine should this kick back up one directory before running the tests with npm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm tasks still run without being in the root directory.

@ccostino
Copy link
Contributor

We're currently running into an issue where the locales available in the Python Docker image (and this is an issue in both the official Python Docker image as well as the CircleCI version) don't support currency formatting, which is used in one of our tests:

======================================================================
ERROR: test_currency_filter_not_none (data.tests.test_utils.TestUtils)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/repo/fec/data/tests/test_utils.py", line 15, in test_currency_filter_not_none
    assert filters.currency(1.05) == '$1.05'
  File "/home/circleci/repo/fec/data/templatetags/filters.py", line 21, in currency
    return locale.currency(num, grouping=grouping)
  File "/usr/local/lib/python3.5/locale.py", line 262, in currency
    raise ValueError("Currency formatting is not possible using "
ValueError: Currency formatting is not possible using the 'C' locale.

----------------------------------------------------------------------

We're trying to figure out ways to solve this because unfortunately we cannot just switch locales to one that will work. The only available ones are C, C.UTF-8, and POSIX, which don't support currency formatting.

@ccostino
Copy link
Contributor

I've commented out the failing test for now, I think it's safe to just get this working and then... circle back on fixing that (sorry!).

Now I'm stuck on a Django SECRET_KEY setting issue, but this is in the deployment step at this point at least!

@ccostino
Copy link
Contributor

Thank you @LindsayYoung for the help with that!

@ccostino
Copy link
Contributor

Hmm, guess we should close this one in favor of PR #1270?

@ccostino ccostino deleted the feature/move-to-circle branch September 25, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants