Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatted_title field to FEC record page #1191

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

noahmanger
Copy link

This adds the formatted_title field to the RecordPage so that you can insert HTML into a title to italicize certain parts.

Just an example to prove it works (wouldn't actually italicize this part):
image

image

Resolves https://github.com/18F/fec-cms/issues/1087

@codecov-io
Copy link

Codecov Report

Merging #1191 into develop will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1191      +/-   ##
===========================================
+ Coverage    63.72%   63.83%   +0.11%     
===========================================
  Files          180      181       +1     
  Lines         5254     5271      +17     
  Branches       403      403              
===========================================
+ Hits          3348     3365      +17     
+ Misses        1880     1878       -2     
- Partials        26       28       +2
Impacted Files Coverage Δ
fec/home/templates/home/updates/record_page.html 83.09% <100%> (ø) ⬆️
fec/home/models.py 85.92% <100%> (+0.04%) ⬆️
fec/home/migrations/0090_auto_20170811_1840.py 100% <100%> (ø)
...ader/management/commands/import_meeting_agendas.py 0% <0%> (ø) ⬆️
...ader/management/commands/scrape_meeting_agendas.py 0% <0%> (ø) ⬆️
fec/home/templates/home/contact.html 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a61291...8547472. Read the comment docs.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@patphongs patphongs merged commit 2a5eddb into develop Aug 11, 2017
@patphongs patphongs deleted the feature/record-formatted-title branch August 11, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants