Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jquery and fullcalendar #1021

Merged
merged 5 commits into from
May 10, 2017
Merged

Updating jquery and fullcalendar #1021

merged 5 commits into from
May 10, 2017

Conversation

noahmanger
Copy link

This updates jQuery to the latest version. In my testing, however, I quickly discovered the calendar was broken, and learned that the library we use for it added support for jQuery 3 in 2.8.0, so I updated that library as well.

Everything seems to work now, but again, another set of eyes wouldn't hurt.

@ccostino
Copy link
Contributor

D'oh, looks like we still have a test failure, but that's because of the fec-style update needed first with 18F/fec-style#686, right @noahmanger?

@noahmanger
Copy link
Author

That's my best bet, because I can't think of any other reason this would fail. The tests pass locally for me.

@codecov-io
Copy link

codecov-io commented May 10, 2017

Codecov Report

Merging #1021 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1021      +/-   ##
==========================================
+ Coverage    62.77%   62.8%   +0.03%     
==========================================
  Files          172     172              
  Lines         4873    4877       +4     
  Branches       375     375              
==========================================
+ Hits          3059    3063       +4     
+ Misses        1797    1795       -2     
- Partials        17      19       +2
Impacted Files Coverage Δ
fec/home/templates/home/calendar.html 100% <0%> (ø) ⬆️
...ader/management/commands/import_meeting_agendas.py 0% <0%> (ø) ⬆️
...ader/management/commands/scrape_meeting_agendas.py 0% <0%> (ø) ⬆️
fec/fec/templates/base.html 83.26% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe147f...ed52b1e. Read the comment docs.

@ccostino ccostino merged commit a1b4183 into develop May 10, 2017
@ccostino ccostino deleted the feature/jquery-upgrade branch May 10, 2017 17:39
@noahmanger noahmanger mentioned this pull request May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants