Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace committee type-ahead to a combined type-ahead and free text search filter #5248

Closed
1 task
Tracked by #159
patphongs opened this issue May 25, 2022 · 3 comments · Fixed by #5408
Closed
1 task
Tracked by #159

Replace committee type-ahead to a combined type-ahead and free text search filter #5248

patphongs opened this issue May 25, 2022 · 3 comments · Fixed by #5408
Assignees
Milestone

Comments

@patphongs
Copy link
Member

patphongs commented May 25, 2022

What we're after:
As a researcher, I want to be able to filter the raw datatables by keyword so that I can return a dataset that is specific to the committee name keyword I'm looking for.

Endpoints spreadsheet: https://docs.google.com/spreadsheets/d/1AkQjXA2XMQfxlRyinSY0uynhf2ZRMh7l_BTWdJgHzXY/edit#gid=0

Filter in pattern library: https://fec-pattern-library.app.cloud.gov/components/detail/type-ahead-and-free-text.html

Where the change needs to be made:

  • All endpoints showing "Done PR" in the endpoints spreadsheet

Completion criteria

  • Committee type-ahead on raw datatables to a combined type-ahead and free text search filter
@patphongs patphongs added this to the Sprint 18.3 milestone May 25, 2022
@djgarr djgarr assigned djgarr and patphongs and unassigned djgarr May 31, 2022
@patphongs patphongs modified the milestones: Sprint 18.3, Sprint 18.6 May 31, 2022
@patphongs patphongs removed their assignment May 31, 2022
@cnlucas cnlucas modified the milestones: Sprint 18.6, Sprint 19.1 Jul 26, 2022
@patphongs
Copy link
Member Author

We've decided to implement this only on filings for now: https://www.fec.gov/data/filings/?data_type=efiling.

@JonellaCulmer JonellaCulmer changed the title Replace committee type-ahead on raw datatables to a combined type-ahead and free text search filter Replace committee type-ahead on filing datatable to a combined type-ahead and free text search filter Aug 11, 2022
@JonellaCulmer JonellaCulmer changed the title Replace committee type-ahead on filing datatable to a combined type-ahead and free text search filter Replace committee type-ahead to a combined type-ahead and free text search filter Aug 16, 2022
@johnnyporkchops
Copy link
Contributor

Where the change needs to be made:

  • All endpoints showing "Done PR" in the endpoints spreadsheet

This is a bit confusing? The completion criterion makes sense, but not sure how I use the spreadsheet for the ticket work?

@johnnyporkchops
Copy link
Contributor

Resolved by PR #5408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants