Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Where Contributions Come From Tool #2929

Closed
3 of 4 tasks
Tracked by #156 ...
JonellaCulmer opened this issue May 31, 2019 · 6 comments · Fixed by #3174
Closed
3 of 4 tasks
Tracked by #156 ...

Build Where Contributions Come From Tool #2929

JonellaCulmer opened this issue May 31, 2019 · 6 comments · Fixed by #3174
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented May 31, 2019

What we're after:
This ticket involves the front-end development of the Where individual contributions come from. Below is a series of mock-ups of the different states our users will encounter while using this chart. Hopefully we can build the chart and add to the feature space in order to conduct usability testing.

Endpoints needed: https://drive.google.com/file/d/1t-wmP_LNNvC1yBeQm6HAq3176NYtEcFD/view

Related issues

List any relevant related issue(s)

Completion criteria

List action items that need to be done to complete this task. List in checklist formatting.

  • Take a look at the code for the maps on the election profile page individual contributions map
  • Find a way to import that map onto the raising-by-the-numbers where contributions come from section
  • Build chart based on mock-ups, please note dividing header borders for greater distinction between the sections, update left nav, and if possible, the reintroduction of the reaction boxes
  • Create pop-up on WCCF with methodology. See Build Where Contributions Come From Tool #2929 (comment)

Designs

Normal/success state

Screen Shot 2019-05-31 at 1 22 12 PM

Normal search state

Screen Shot 2019-05-31 at 1 22 21 PM

Error state for no data

Screen Shot 2019-05-31 at 1 22 30 PM

Error state for missing candidate

Screen Shot 2019-05-31 at 1 22 38 PM

Entire Raising: by the numbers page

Screen Shot 2019-05-31 at 1 25 45 PM

@jason-upchurch
Copy link
Contributor

@rfultz I submitted PR for review to support the "All states" portion of the chart: fecgov/openFEC#3835

@dorothyyeager dorothyyeager modified the milestones: Sprint 9.4, Sprint 9.5 Jul 12, 2019
@rfultz
Copy link
Contributor

rfultz commented Jul 26, 2019

(down to getting the datatable to display and refresh its data)

@rfultz
Copy link
Contributor

rfultz commented Jul 29, 2019

Spent way too much time fighting with datatables; gave up and built my own table. Roadblock removed

@dorothyyeager dorothyyeager modified the milestones: Sprint 9.5, Sprint 9.6 Jul 30, 2019
@rfultz
Copy link
Contributor

rfultz commented Aug 5, 2019

Implementing error handling, states, messages, and styles

@rfultz rfultz changed the title Build where contributions come from chart Build Where Contributions Come From Tool Aug 16, 2019
@rfultz
Copy link
Contributor

rfultz commented Aug 16, 2019

Quick progress update: It works! (Still need to style, break the legend into five…)

image

@JonellaCulmer
Copy link
Contributor Author

JonellaCulmer commented Sep 3, 2019

The Methodology needed for this work can be found here: #3123 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment