Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mis-labelled AOs #1361

Closed
2 tasks
Tracked by #113
patphongs opened this issue Oct 23, 2017 · 9 comments
Closed
2 tasks
Tracked by #113

Mis-labelled AOs #1361

patphongs opened this issue Oct 23, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@patphongs
Copy link
Member

patphongs commented Oct 23, 2017

It has been reported that some AOs are mislabeled in both the PDF and the tab name. See screenshot below of AO 2015-09, which labels it as AO 2009-18 in the grey bar at the top of the PDF as well as in the <title> tags <title>ADVISORY OPINION 2009-18</title>.

  • investigate how title tags are populated
  • fix title tags

image003

@patphongs patphongs added the Bug label Oct 23, 2017
@PaulClark2 PaulClark2 added this to the Sprint 4.3 milestone Oct 31, 2017
@jwchumley jwchumley modified the milestones: Sprint 4.3, Sprint 4.4 Oct 31, 2017
@jwchumley jwchumley modified the milestones: Sprint 4.4, Sprint 4.5 Nov 14, 2017
@vrajmohan
Copy link
Contributor

vrajmohan commented Nov 14, 2017

Are the AOs mislabeled anywhere except the gray bar at the top of the PDF in Google Chrome? Do we have additional examples?

Tagging @AmyKort.

@AmyKort
Copy link

AmyKort commented Nov 14, 2017

https://www.fec.gov/files/legal/aos/63615.pdf 2007-05 is labeled on the gray bar as 2007-03. 2007-03 is also labeled (correctly) as 2007-03).

I will keep looking. I'm only seeing this error on the gray bar.

@AmyKort
Copy link

AmyKort commented Nov 14, 2017

2007-02 reads 2004-34 on the bar https://www.fec.gov/files/legal/aos/68692.pdf

2007-04 reads 2004-34 on the bar https://www.fec.gov/files/legal/aos/63644.pdf

2011-04 reads 72764 on the bar https://www.fec.gov/files/legal/aos/72764.pdf

@vrajmohan
Copy link
Contributor

vrajmohan commented Nov 14, 2017

It looks like the defect is in the metadata inside the published PDFs themselves. It looks like Google Chrome's PDF viewer uses this metadata to display the title of the PDF. The only way to fix this would be to fix the metadata in the original source PDFs and reload them.

This metadata is not used by Firefox or Safari.

@AmyKort
Copy link

AmyKort commented Nov 15, 2017

What would be involved in fixing the metadata in the original pdfs? cc @jwchumley

@vrajmohan
Copy link
Contributor

FYI, this can be demonstrated on the classic site, e.g., http://saos.fec.gov/aodocs/2007-02.pdf.

@AmyKort
Copy link

AmyKort commented Nov 15, 2017

Thanks, @vrajmohan . I think we should close out this ticket since it is not something we can fix on your end. I will open a new ticket for future work to look into the metadata in our pdfs. Thank you so much for getting to the bottom of this so quickly!

@vrajmohan vrajmohan assigned AmyKort and unassigned vrajmohan Nov 15, 2017
@vrajmohan
Copy link
Contributor

Agreed. Assigning it to @AmyKort to close after new upstream ticket is opened.

@AmyKort
Copy link

AmyKort commented Nov 16, 2017

We'll take the next steps on this at fecgov/openFEC-web-app#2342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants