Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement front end styling changes to adv. data page/feed #1309

Closed
5 tasks
Tracked by #127
PaulClark2 opened this issue Oct 4, 2017 · 0 comments
Closed
5 tasks
Tracked by #127

Implement front end styling changes to adv. data page/feed #1309

PaulClark2 opened this issue Oct 4, 2017 · 0 comments
Assignees

Comments

@PaulClark2
Copy link
Contributor

PaulClark2 commented Oct 4, 2017

This issue was moved over from the web app and specified. Original issue: fecgov/openFEC-web-app#2330

What we're after This set of changes prepares the advanced data page template to receive the data catalog data that was mapped into each section. It focuses on adjusting the styling, but stops short of adding the content in, which will be addressed in a separate issue. It's broken down this way to keep the issues small and manageable.


Designs from fecgov/openFEC-web-app#2318

🖥 Invision prototype

This prototype shows how we might distribute the different data sets (from the data catalog and the FTP). The accordions are clickable and indicate how we might label and group data by year, as well as how we can create the space to describe the data within it.

Basic page styling:

screen shot 2017-10-26 at 4 22 10 pm

Basic expanded accordion styling, and differences in accordion content

screen shot 2017-10-26 at 4 23 30 pm
screen shot 2017-10-26 at 4 24 04 pm
screen shot 2017-10-26 at 4 24 17 pm


Completion criteria

  • Change advanced data template styles to match designs
    • Removes "feed" styling (removes lines between each item and nested/structured/indented relationships between data sets
    • Removes document icon for collected data sets
    • Changes data set titles to all h4
    • Adds magnifying icon in front of each searchable data set: this helps keep the focus on these features
  • Create/Edit accordion pattern to match the design
    • Change body copy from serif to sans-serif
    • Prepare to accommodate icons, links, headers, and body paragraph styles within the panel
    • The work for this issue should create the styling and markup for the accordion patterns used on the page (Starting with and updating the accordion in the pattern library), but should not place them into the page yet: it's just to prepare the template for being filled.
  • Update accordion pattern in pattern library
    The only other place on the site using our stock pattern accordions right now (that I know of) is the latest updates page. so if there's time:
    • Update accordion pattern on latest updates page to match new styling. (If there isn't time, separate this out into a smaller issue that would be easy to pick up)
  • Check mobile styling
@PaulClark2 PaulClark2 added this to the Sprint 4.2 milestone Oct 4, 2017
@jenniferthibault jenniferthibault changed the title Front end styling changes to adv. data page/feed Implement front end styling changes to adv. data page/feed Oct 26, 2017
@PaulClark2 PaulClark2 modified the milestones: Sprint 4.3, Sprint 4.4 Nov 7, 2017
@jwchumley jwchumley modified the milestones: Sprint 4.4, RBS 1 (Reliability, stability and bugs) Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants