Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new page for downloading presidential public fund submission files in Wagtail #1406

Closed
4 of 6 tasks
Tracked by #127
jenniferthibault opened this issue Oct 27, 2017 · 16 comments
Closed
4 of 6 tasks
Tracked by #127
Assignees

Comments

@jenniferthibault
Copy link
Contributor

jenniferthibault commented Oct 27, 2017

Moved from design and content modeling issues in fecgov/openFEC-web-app#2318


Designs

🎨 InVision Prototype of Presidential matching fund submissions page

Page sources on classic


Completion criteria

Migrate the content and downloads to a new site

  • In Wagtail, make a child page of the Presidential public funding page using the "Custom page" template

    • Page title: Presidential matching fund submissions
    • Intro copy: In addition to regular quarterly or monthly disclosure reports, presidential candidates who seek matching funds must submit information about matchable contributions to the FEC for review.
    • Link: Learn about the presidential public funding program » back to https://www.fec.gov/press/resources-journalists/presidential-public-funding/
  • Use custom HTML tables to format presidential public funds submissions back to 2000. Match to designs in prototype linked above.

  • Link to downloads that live in the new s3 environments (not Waltham)

  • Publish the new page!

Then, help people get to the new page

  • In Wagtail, add Related topic link and in copy link to new page on Presidential public funding page
    • screen shot 2017-10-26 at 11 12 58 pm
  • In HTML files, add link to new page from Candidates tab of Advanced data page
    • screen shot 2017-10-26 at 11 14 41 pm
@jwchumley
Copy link

Dependency: Fixing the HTML wagtail bug.

@PaulClark2 PaulClark2 modified the milestones: Sprint 4.3, Sprint 4.4 Nov 7, 2017
@johnnyporkchops
Copy link
Contributor

@jenniferthibault
Copy link
Contributor Author

@johnnyporkchops you're very close on the sidebar formatting. I inspected another page using the same module successfully, and found that the secret to getting it to render correctly is to use the Heading block separately from the body.

Correct formatting use

screen shot 2017-11-13 at 3 51 20 pm

Current formatting use
screen shot 2017-11-13 at 3 58 29 pm

@jenniferthibault
Copy link
Contributor Author

Also worth noting that this issue will be blocked from 100% completion until we can link to this page from the Candidates section of the Advanced data page. (The last completion criteria above)

That was intended to require the restyling in https://github.com/18f/fec-cms/issues/1309 ... though it's possible to add it in using the current styles.

@llienfec
Copy link
Contributor

Talked to the auditor that handles the Title 26 audits. Her feedback was incredibly positive. Said she loved how clear and organized these pages were, everything makes sense, everything is in one place and you feel like you found everything you need. She said she's really impressed with the new site and thinks it's awesome for users. Really good job all!

cc: @AmyKort

@patphongs patphongs modified the milestones: Sprint 4.4, RBS 1 (Reliability, stability and bugs) Nov 28, 2017
@johnnyporkchops
Copy link
Contributor

The wagtail drafts of the two pres funding pages are here:
New pres public funding submission page:
https://fec-prod-proxy.app.cloud.gov/admin/pages/9369/view_draft/
Draft of pres public funding page w/ new link:
https://fec-prod-proxy.app.cloud.gov/admin/pages/113/revisions/15921/view/

Here is a screenshot for the candidates tab above in the adv data page PR
candidates_tab

@PaulClark2
Copy link
Contributor

What's the status of this issue?

1 similar comment
@AmyKort
Copy link

AmyKort commented Feb 15, 2018

What's the status of this issue?

@llienfec
Copy link
Contributor

My part of getting the approvals from Audit is finished!

@AmyKort
Copy link

AmyKort commented Mar 15, 2018

Is publication of this page blocked by work to complete the advanced data pages?

@jenniferthibault
Copy link
Contributor Author

@johnnyporkchops can you speak to this?
It looks like from your screenshot above that the link is implemented in the Adv data page page, and the link is live from the Press page here: https://www.fec.gov/press/resources-journalists/presidential-public-funding/

@AmyKort
Copy link

AmyKort commented Apr 4, 2018

The link from the press page is returning a 404. Will that be resolved when we publish the Advanced Data pages?

image

@llienfec
Copy link
Contributor

llienfec commented Apr 4, 2018

Oh! I saw a section for this when I was looking at bulk downloads this morning. What would you think of sending it here:
image

The only downside is that it's lower on this page: https://www.fec.gov/data/advanced/?tab=other
We're not able to send someone directly to the presidential section of the page because anchor tags don't work in Wagtail. Still worth the link?

@AmyKort
Copy link

AmyKort commented Jun 6, 2018

What's the status of this issue?

@llienfec
Copy link
Contributor

The broken link above looks like it doesn't exist anymore with the completion of the presidential public funding section.

@johnnyporkchops: can you speak to the rest of this issue?

@dorothyyeager
Copy link
Contributor

I actually just noticed that link as well. Press has discontinued that page since we've got the public funding section up. I'd recommend linking it to https://www.fec.gov/introduction-campaign-finance/understanding-ways-support-federal-candidates/presidential-elections/public-funding-presidential-elections/#reports-and-resources (since that will take them to the part where they can access list of public funding recipients).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants