Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changes to Introduction to campaign finance and elections panel on homepage #1237

Closed
2 of 5 tasks
Tracked by #126
jenniferthibault opened this issue Sep 6, 2017 · 10 comments
Closed
2 of 5 tasks
Tracked by #126
Assignees
Milestone

Comments

@jenniferthibault
Copy link
Contributor

jenniferthibault commented Sep 6, 2017


History and discussion in https://github.com/18F/fec-cms/issues/1182


Designs

screen shot 2017-09-06 at 5 37 16 pm


Notes:

Links:

Images
📁 Getting-started-images.zip
These images will get us started, and I can make tweaks later if needed. The FEC owns the first image, the second is a photo from the US Navy that we can use because it's govt works, and the third is one I made quickly to keep things moving with images we have rights for.
I wasn't sure what's best to name them

Steps to completion

  • Create anchor links to the sections of the data landing page so that we can link to it from the middle tile's button (this seems useful to the future as well)
  • Rename images to something that makes sense
  • Rebuild Introduction to campaign finance home page section (this may need more grooming and fleshing out from @xtine's help )

⚠️ Dependencies for release

@dorothyyeager
Copy link
Contributor

Hi @jenniferthibault - I can't check it off above, but I took off the password from the citizens' pages and published "Understanding ways to support federal candidates." The pages are live but still private and viewable only by logged in users. Let me know if I need to make that page public.

Also, I made a new issue yesterday #1233 for a page we want to create in this section. I think it will end up being another page we link to (or alternately, since the limits are covered in the "understanding ways" section). It deals with non-FEC things. Just wanted to make sure that is on everyone's radar.

@dorothyyeager
Copy link
Contributor

One more thought/issue to cross-reference - some of the brochures linked on that Understanding Ways page are undergoing revision or discussions about retirement. See https://github.com/18F/fec-cms/issues/1215 and discussion in google document (linked in Slack content channel).

@jenniferthibault
Copy link
Contributor Author

In design pairing today we reviewed the copy and made some tweaks to make the structure of each more consistent. Here's what we landed on for v1 under each image:

__

Find out how individuals can support federal candidates
Including making contributions, volunteering, internet activities and filing complaints
[Start learning] >
__

Explore financial data for current and past elections and the candidates in those races
[Compare candidates] >
__

Learn about how much contributors can give to different types of committees
[Get the contribution limits] >

@dorothyyeager
Copy link
Contributor

dorothyyeager commented Sep 15, 2017

Sounds good. I will go into the supporting candidates section we are linking to and update any needed links (mentioned above in my last comment) since we closed out #1215 and some of those links may need modification.

And coming back to verify that everything on that supporting candidates page is current. Some of the linked brochures will get updates in the future, but as of now, we are good.

@patphongs
Copy link
Member

Implementation of this within https://github.com/18F/fec-cms/pull/1290 is complete. Closing this ticket as design for this will also be reviewed within that PR.

@jenniferthibault
Copy link
Contributor Author

@patphongs to keep the work visible (and to keep the pressure on for reviewing PRs) our practice has been to keep an issue open, labeled as "Done" until the PR with the changes in it is reviewed and merged. Going to reopen this issue to keep with that practice

@AmyKort
Copy link

AmyKort commented Oct 31, 2017

Where are we on this issue?

@patphongs patphongs modified the milestones: Sprint 4.1, Sprint 4.3 Oct 31, 2017
@patphongs
Copy link
Member

@AmyKort That will be in my court to review the PRs that John has submitted, which includes this new design for the homepage. I will be doing that this sprint (4.3) and hopefully we can get them merged in.

@AmyKort
Copy link

AmyKort commented Oct 31, 2017

Thanks!

@jenniferthibault
Copy link
Contributor Author

Released on 11/21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants