Upgrade ESLint, resolve errors (#3126)

* Upgrade ESLint, resolve errors * Update dependencies version warnings * Linting * Address Date Filter inputmasks * Undo jquery.inputmask > inputmask upgrade * Switch back to jquery.inputmask * Removing inputmask (for now)
fecgov · Sep 16, 2019 · 67a20c3 · 67a20c3
1 parent 66794b7
commit 67a20c3
Show file tree

Hide file tree

Showing 43 changed files with 506 additions and 426 deletions.
diff --git a/fec/fec/static/js/modules/accessibility.js b/fec/fec/static/js/modules/accessibility.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global module */
-
 /**
  * Utilities for setting or removing tabindex on all focusable elements
  * in a parent div. Useful for hiding elements off-canvas without setting

diff --git a/fec/fec/static/js/modules/analytics.js b/fec/fec/static/js/modules/analytics.js
@@ -1,9 +1,5 @@
 'use strict';
 
-/* global ga */
-
-// TODO - should this all be moved into Tag Manager?
-
 var _ = require('underscore');
 var URI = require('urijs');
 

diff --git a/fec/fec/static/js/modules/cycle-select.js b/fec/fec/static/js/modules/cycle-select.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global context */
-
 var $ = require('jquery');
 var _ = require('underscore');
 var URI = require('urijs');

diff --git a/fec/fec/static/js/modules/election-search.js b/fec/fec/static/js/modules/election-search.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global window */
-
 var $ = require('jquery');
 var URI = require('urijs');
 var _ = require('underscore');

diff --git a/fec/fec/static/js/modules/election-summary.js b/fec/fec/static/js/modules/election-summary.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, module */
-
 var $ = require('jquery');
 var URI = require('urijs');
 

diff --git a/fec/fec/static/js/modules/election-utils.js b/fec/fec/static/js/modules/election-utils.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, module */
-
 var $ = require('jquery');
 var _ = require('underscore');
 var fips = require('./fips');

diff --git a/fec/fec/static/js/modules/events.js b/fec/fec/static/js/modules/events.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, module, window */
-
 var eventemitter = require('eventemitter2');
 var EventEmitter2 = eventemitter.EventEmitter2 || eventemitter;
 module.exports = window.events = window.events || new EventEmitter2();
diff --git a/fec/fec/static/js/modules/filings.js b/fec/fec/static/js/modules/filings.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, module */
-
 var $ = require('jquery');
 var _ = require('underscore');
 

diff --git a/fec/fec/static/js/modules/filters/date-filter.js b/fec/fec/static/js/modules/filters/date-filter.js
@@ -3,7 +3,7 @@
 var $ = require('jquery');
 var moment = require('moment');
 
-var Filter = require('./filter-base.js');
+var Filter = require('./filter-base');
 
 require('jquery.inputmask');
 require('jquery.inputmask/dist/inputmask/inputmask.date.extensions');

diff --git a/fec/fec/static/js/modules/filters/validate-date-filters.js b/fec/fec/static/js/modules/filters/validate-date-filters.js
@@ -3,11 +3,10 @@
 var $ = require('jquery');
 var moment = require('moment');
 
-var Filter = require('./filter-base.js');
+var Filter = require('./filter-base');
 
 require('jquery.inputmask');
-require('jquery.inputmask/dist/inputmask/inputmask.date.extensions.js');
-require('jquery.inputmask/dist/inputmask/inputmask.numeric.extensions.js');
+require('jquery.inputmask/dist/inputmask/inputmask.date.extensions');
 
 /**
  * ValidateDateFilter

diff --git a/fec/fec/static/js/modules/fips.js b/fec/fec/static/js/modules/fips.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, module */
-
 var _ = require('underscore');
 
 function byField(values, key) {

diff --git a/fec/fec/static/js/modules/helpers.js b/fec/fec/static/js/modules/helpers.js
@@ -518,6 +518,7 @@ function sanitizeQueryParams(query) {
   var param;
 
   for (param in query) {
+    // eslint-disable-next-line no-prototype-builtins
     if (query.hasOwnProperty(param)) {
       query[param] = sanitizeValue(query[param]);
     }

diff --git a/fec/fec/static/js/modules/keyword-modal.js b/fec/fec/static/js/modules/keyword-modal.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global ga */
-
 var $ = require('jquery');
 var URI = require('urijs');
 var A11yDialog = require('a11y-dialog');

diff --git a/fec/fec/static/js/modules/line-chart-committees.js b/fec/fec/static/js/modules/line-chart-committees.js
@@ -1,6 +1,6 @@
 'use strict';
 
-/* global module, DEFAULT_TIME_PERIOD */
+/* global DEFAULT_TIME_PERIOD */
 var $ = require('jquery');
 var _ = require('underscore');
 var d3 = require('d3');

diff --git a/fec/fec/static/js/modules/line-chart.js b/fec/fec/static/js/modules/line-chart.js
@@ -1,6 +1,6 @@
 'use strict';
 
-/* global module, DEFAULT_TIME_PERIOD */
+/* global DEFAULT_TIME_PERIOD */
 var $ = require('jquery');
 var _ = require('underscore');
 var d3 = require('d3');

diff --git a/fec/fec/static/js/modules/other-spending-totals.js b/fec/fec/static/js/modules/other-spending-totals.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, context */
-
 var $ = require('jquery');
 var _ = require('underscore');
 

diff --git a/fec/fec/static/js/modules/performance.js b/fec/fec/static/js/modules/performance.js
@@ -1,6 +1,6 @@
 'use strict';
 
-/* global require, module, window, perfBar */
+/* global perfBar */
 
 var _ = require('underscore');
 

diff --git a/fec/fec/static/js/modules/skip-nav.js b/fec/fec/static/js/modules/skip-nav.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, module, document */
-
 var $ = require('jquery');
 
 /**

diff --git a/fec/fec/static/js/modules/toggle.js b/fec/fec/static/js/modules/toggle.js
@@ -1,6 +1,5 @@
 'use strict';
 
-/* global require, module, document */
 var $ = require('jquery');
 
 module.exports = {

diff --git a/fec/fec/static/js/pages/bythenumbers.js b/fec/fec/static/js/pages/bythenumbers.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global context, ga */
-
 var $ = require('jquery');
 var analytics = require('../modules/analytics'); // TODO - move this to Tag Manager?
 var TopEntities = require('../modules/top-entities').TopEntities;

diff --git a/fec/fec/static/js/pages/candidate-single.js b/fec/fec/static/js/pages/candidate-single.js
@@ -1,6 +1,6 @@
 'use strict';
 
-/* global require, document, context, WEBMANAGER_EMAIL */
+/* global WEBMANAGER_EMAIL */
 
 var $ = require('jquery');
 var URI = require('urijs');

diff --git a/fec/fec/static/js/pages/committee-single.js b/fec/fec/static/js/pages/committee-single.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global document, context */
-
 var $ = require('jquery');
 var _ = require('underscore');
 var URI = require('urijs');

diff --git a/fec/fec/static/js/pages/contact-form.js b/fec/fec/static/js/pages/contact-form.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global window */
-
 var $ = require('jquery');
 var Typeahead = require('../modules/typeahead').Typeahead;
 var URI = require('urijs');

diff --git a/fec/fec/static/js/pages/data-browse-data.js b/fec/fec/static/js/pages/data-browse-data.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require */
-
 var $ = require('jquery');
 
 var LineChartCommittees = require('../modules/line-chart-committees')

diff --git a/fec/fec/static/js/pages/data-landing.js b/fec/fec/static/js/pages/data-landing.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, ga */
-
 var $ = require('jquery');
 var lookup = require('../modules/election-lookup');
 var analytics = require('../modules/analytics'); // TODO - move this to Tag Manager?

diff --git a/fec/fec/static/js/pages/datatable-candidates-office.js b/fec/fec/static/js/pages/datatable-candidates-office.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global context */
-
 var $ = require('jquery');
 
 var tables = require('../modules/tables');

diff --git a/fec/fec/static/js/pages/datatable-committees.js b/fec/fec/static/js/pages/datatable-committees.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global document */
-
 var $ = require('jquery');
 
 var tables = require('../modules/tables');

diff --git a/fec/fec/static/js/pages/datatable-disbursements.js b/fec/fec/static/js/pages/datatable-disbursements.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global document */
-
 var $ = require('jquery');
 
 var tables = require('../modules/tables');

diff --git a/fec/fec/static/js/pages/datatable-filings.js b/fec/fec/static/js/pages/datatable-filings.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, document */
-
 var $ = require('jquery');
 
 var filings = require('../modules/filings');

diff --git a/fec/fec/static/js/pages/datatable-operating-expenditures.js b/fec/fec/static/js/pages/datatable-operating-expenditures.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global document */
-
 var $ = require('jquery');
 
 var tables = require('../modules/tables');

diff --git a/fec/fec/static/js/pages/datatable-reports.js b/fec/fec/static/js/pages/datatable-reports.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, document, context */
-
 var $ = require('jquery');
 
 var tables = require('../modules/tables');

diff --git a/fec/fec/static/js/pages/election-lookup.js b/fec/fec/static/js/pages/election-lookup.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global require, document */
-
 var $ = require('jquery');
 var lookup = require('../modules/election-search');
 

diff --git a/fec/fec/static/js/pages/elections.js b/fec/fec/static/js/pages/elections.js
@@ -1,7 +1,5 @@
 'use strict';
 
-/* global document, context */
-
 var $ = require('jquery');
 var _ = require('underscore');
 

diff --git a/fec/fec/static/js/pages/legal.js b/fec/fec/static/js/pages/legal.js
@@ -1,6 +1,5 @@
 'use strict';
 
-/* global require */
 var FilterPanel = require('../modules/filters/filter-panel').FilterPanel;
 var KeywordModal = require('../modules/keyword-modal').KeywordModal;