Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #889 (wrong color to play) #890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Jul 20, 2021

(Caution: You also need to apply #766 to handle initial stones correctly in Lizzie 0.7.4.)

This patch fixes both #889 and another issue (handicap stones are not cleared for background engines) in Lizzie 0.7.3:

  1. Start Lizzie.
  2. Paste (;AB[dd]).
  3. Switch the engine to Engine1.
  4. Click "ClearBoard" button in the toolbar.
  5. Switch the engine to Engine0 again.
  6. Click "Analyze > Clear analysis" in the menu.

The board is empty at 6, but no candidate appears around the top left corner.

Notes

This patch is just a workaround. It will be better to specify player explicitly in lz-analyze like lz-analyze b 10 instead of lz-analyze 10. I did not do it this time because I am not sure whether Lizzie.board.getData().blackToPlay (or Lizzie.board.getHistory().isBlacksTurn()) is always updated correctly before pondering.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jul 20, 2021

Ideally, we should support PL property in SGF to specify who to play if there are both black and white stones in the initial setup. See also Katrain's smarter way. sanderland/katrain#293

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Aug 26, 2021
@kaorahi kaorahi mentioned this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant