Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in comment area #879

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Mar 9, 2021

Issue A:

#676 (word wrap). Compared to #696, this PR will be more friendly with the existing code of Lizzie 0.7.4.

(;SZ[19]C[long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long line
and
looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong line])

Issue B:

In Panel UI, comments with many lines are scrolled to the bottom initially. The top lines should be visible initially for convenience.

(Try the sample SGF in #877.)

Issue C:

On Lizzie 0.7.4, score 5 is shown in the comment area by the following SGF due to insufficient HTML escaping. It should be score < 5.

(;SZ[19]C[score < 5])

Issue D:

  1. Start Lizzie 0.7.4 with Normal UI (not Panel UI) and paste the following SGF.
  2. Move the mouse cursor to the center of the comment area (the black rectangle at the bottom right)
  3. Move the mouse wheel. Then the comment area is moved upward.
  4. Move the mouse cursor into the main board. Then the comment area returns to the normal position.

I expect nothing happens in the step 3.

(;SZ[19]C[abc])

In addition, this PR may also help future implementation of #806. (only in Panel UI because of #877)

I dare to keep the obsolete name commentPane, that is not JTextPane but JTextArea now. I'd like to make changes as small as possible to avoid conflicts with other patches.

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Mar 12, 2021
@kaorahi kaorahi mentioned this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant