Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: About display comment of sgf and read/write sgf with variation & Winrate. #352

Closed
wants to merge 19 commits into from

Conversation

zsalch
Copy link
Contributor

@zsalch zsalch commented Aug 23, 2018

Closes #350

  1. Add the display the comment of the sgf (C tag): Forgive me very lazy, directly displayed under the variation panel, please ignore the ugly style :(
  2. Add the ability to read and write the sgf with variation
  3. By the way, write the Winrate in the comment of sgf for each step (C tag): Just a little try

@zsalch
Copy link
Contributor Author

zsalch commented Aug 24, 2018

new update:
fix the Winrate wrong when load the sgf with variation.

@featurecat
Copy link
Owner

sorry for the wait. I'll review this tomorrow!

@zsalch
Copy link
Contributor Author

zsalch commented Aug 31, 2018

Thanks for your reply. Please ignore last commit (bd81db6: 2018/08/29 Multiple Weights Switching).
This is a pending change. I will discard the commit.

@OlivierBlanvillain
Copy link
Contributor

@zsalch Could you please split this work into 3 distinct pull requests? Having everything in a single diff makes it hard to review.

Also, I personally dislike the idea of writing the win-rate in the SGF file. People have developed dedicated tools that might be better suited to do offline analysis of SGF files, it's not clear to me why this feature should be within the scope of Lizzie...

@zsalch
Copy link
Contributor Author

zsalch commented Sep 17, 2018

@OlivierBlanvillain
I got it and will split the pull request.

About writing win-rate, some people like do it. I'll default turn off the feature and change it to be a hidden option in the config.txt.

@zsalch
Copy link
Contributor Author

zsalch commented Sep 18, 2018

Close this pull request and split two new pull request: #364 #365

@zsalch zsalch closed this Sep 18, 2018
@OlivierBlanvillain
Copy link
Contributor

@zsalch Did you end up committing the winrate to comment feature? (#308)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants