-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next: About display comment of sgf and read/write sgf with variation & Winrate. #352
Conversation
new update: |
sorry for the wait. I'll review this tomorrow! |
Thanks for your reply. Please ignore last commit (bd81db6: 2018/08/29 Multiple Weights Switching). |
@zsalch Could you please split this work into 3 distinct pull requests? Having everything in a single diff makes it hard to review. Also, I personally dislike the idea of writing the win-rate in the SGF file. People have developed dedicated tools that might be better suited to do offline analysis of SGF files, it's not clear to me why this feature should be within the scope of Lizzie... |
@OlivierBlanvillain About writing win-rate, some people like do it. I'll default turn off the feature and change it to be a hidden option in the config.txt. |
Closes #350