Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node blunder colors don't work in the default theme #423

Open
featurecat opened this issue Nov 8, 2018 · 3 comments
Open

Node blunder colors don't work in the default theme #423

featurecat opened this issue Nov 8, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@featurecat
Copy link
Owner

@zsalch

For now, it's not a big problem. It can be an optional feature, especially since I think the colors need to be chosen more carefully. I think a gradient from green to neutral to red would be best. Green for "good moves", red for "bad moves"

@featurecat featurecat added the bug Something isn't working label Nov 8, 2018
@zsalch
Copy link
Contributor

zsalch commented Nov 8, 2018

Yes, I think we need a good color solution.

@atoutw
Copy link

atoutw commented Nov 15, 2018

For your reference, this is mine.
[ 255, 0, 0 ],
[ 255, 120, 0 ],
[ 255, 200, 0 ],
[ 255, 255, 0 ],
[ 150, 255, 0 ],
[ 0, 255, 0 ]
],
"blunder-winrate-thresholds": [ -30, -20, -10.1, -5.1, 5, 10.1 ]

image
image

@featurecat
Copy link
Owner Author

thank you! :)

does anyone have a reason not to use a gradient from green to yellow to red? otherwise I will just make it the default, configurable on/off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants