Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Start git-ignoring .vscode/settings.json #452

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Start git-ignoring .vscode/settings.json #452

merged 1 commit into from
Jul 20, 2019

Conversation

bravo-kernel
Copy link
Contributor

@bravo-kernel bravo-kernel commented Jul 20, 2019

This file should be git-ignored as it is intended for (and may contain) user specific settings. For example, VSCode extensions usually store user-preferences in this file so we don't want to commit them to the repository.

Since we are not distributing the settings.json file with the generator this change should be harmless but will improve the user experience for VSCode users (not being surprised by .vscode entries appearing in their git status).

@daffl
Copy link
Member

daffl commented Jul 20, 2019

Yup makes sense, thank you!

@daffl daffl merged commit cad42f9 into feathersjs-ecosystem:master Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants