This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Use pg@6 #247
Merged
Use pg@6 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grrr.... looks to be failing on RethinkDB. Something about no connection pools. Maybe the RethinkDB just isn't ready for connections by the time the test is run. I'll pull this branch down and manually verify that PG works at least. |
|
The RethinkDB stuff just started failing a couple of days ago. I just created a follow-up issue at #248 |
|
Let's skip the RethinkDB tests for now. |
|
ok PG seems to be working locally. |
daffl
previously requested changes
Jul 19, 2017
generators/connection/index.js
Outdated
| @@ -37,7 +37,7 @@ module.exports = class ConnectionGenerator extends Generator { | |||
| mariadb: 'mysql', | |||
| mysql: 'mysql', | |||
There was a problem hiding this comment.
Could you also change this to mysql2 while we're at it? That's what I got a complaint about.
|
Woot! Thanks @marshallswain, you wanna do a new patch release? |
|
I already did, but I guess I should follow up. 😉 Released as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a problem described in #246