-
Notifications
You must be signed in to change notification settings - Fork 131
Conversation
Grrr.... looks to be failing on RethinkDB. Something about no connection pools. Maybe the RethinkDB just isn't ready for connections by the time the test is run. I'll pull this branch down and manually verify that PG works at least. |
The RethinkDB stuff just started failing a couple of days ago. I just created a follow-up issue at #248 |
Let's skip the RethinkDB tests for now. |
ok PG seems to be working locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change and probably skip RethinkDB tests.
generators/connection/index.js
Outdated
@@ -37,7 +37,7 @@ module.exports = class ConnectionGenerator extends Generator { | |||
mariadb: 'mysql', | |||
mysql: 'mysql', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also change this to mysql2
while we're at it? That's what I got a complaint about.
Woot! Thanks @marshallswain, you wanna do a new patch release? |
I already did, but I guess I should follow up. 😉 Released as |
Addresses a problem described in #246